[vlc-devel] [PATCH] vout: Overlay for Parrot Asteroid devices

[Jean-Baptiste Kempf]

On 19 Jun, Andrei Mandychev wrote :
> The patch 0001-vout-Overlay-for-Parrot-Asteroid-devices.patch provides
> conditional blocks to render video by TI overlay for Parrot Asteroid
> devices.


>  +#ifdef PARROT_MEDIA_OUT
>  +
>  +#define SCREEN_PRIMARY_LCD      0
>  +#define SCREEN_SECONDARY_LCD_   1
>  +#define SCREEN_COMPOSITE_TV     2

Enum, please.

>  +#define ANDROID_SYM_OVR_DESTROY "_ZN7android7Overlay7destroyEv"
>  +#define ANDROID_SYM_OVR_DEQUEUE_BUF "_ZN7android7Overlay13dequeueBufferEPPv"
>  +#define ANDROID_SYM_OVR_QUEUE_BUF "_ZN7android7Overlay11queueBufferEPv"
>  +#define ANDROID_SYM_OVR_GET_BUF_ADDR "_ZN7android7Overlay16getBufferAddressEPv"
>  +#define ANDROID_SYM_OVR_GET_BUF_COUNT "_ZNK7android7Overlay14getBufferCountEv"

Why are those PARROT specific? They don't exist in the rest of Android?

>  +#ifdef PARROT_MEDIA_OUT
>  +
>  +/* possible overlay formats */
>  +enum {
>  +    OVERLAY_FORMAT_RGBA_8888    = 1,
>  +    OVERLAY_FORMAT_RGB_565      = 4,
>  +    OVERLAY_FORMAT_BGRA_8888    = 5,
>  +    OVERLAY_FORMAT_YCbCr_422_SP = 0x10, // NV16
>  +    OVERLAY_FORMAT_YCbYCr_422_I = 0x14,
>  +    OVERLAY_FORMAT_YCbYCr_420_I = 0x15,
>  +    OVERLAY_FORMAT_CbYCrY_422_I = 0x16,
>  +    OVERLAY_FORMAT_CbYCrY_420_I = 0x17,
>  +    OVERLAY_FORMAT_YCbCr_420_SP = 0x21,
>  +    OVERLAY_FORMAT_YCbCr_420_SP_SEQ_TB = 0x24, //NV12 Interlaced (Sequential Top-Bottom)
>  +    OVERLAY_FORMAT_DEFAULT      = 99,    // The actual color format is determined by the overlay
>  +};
>  +typedef void ISurface;
>  +typedef void Overlay;
>  +typedef int32_t status_t;
>  +
>  +typedef ISurface* (*getISurface)(void *);
>  +typedef Overlay* (*createOverlay)(void *, uint32_t, uint32_t, int32_t, int32_t);
>  +typedef void (*releaseOverlay)();
>  +typedef void (*setDisplay)(void *, int);
>  +
>  +// _ZN7android7Overlay7destroyEv
>  +typedef void (*Overlay_destroy)(void *);
>  +// ZN7android7Overlay13dequeueBufferEPPv
>  +typedef status_t (*Overlay_dequeueBuffer)(void *, int *);
>  +// ZN7android7Overlay11queueBufferEPv
>  +typedef status_t (*Overlay_queueBuffer)(void *, int);
>  +// ZN7android7Overlay16getBufferAddressEPv
>  +typedef void* (*Overlay_getBufferAddress)(void *, int);
>  +// ZNK7android7Overlay14getBufferCountEv
>  +typedef int32_t (*Overlay_getBufferCount)(void *);
>  +
>  +#endif /* PARROT_MEDIA_OUT */

Idem?

>  +#ifdef PARROT_MEDIA_OUT
>  +    fmt.i_chroma = VLC_CODEC_UYVY;

Why?
And why not using the option for that?


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device