[vlc-devel] [PATCH]live555: Support playing Theora video RTP streams

[Rémi Denis-Courmont]

Le mardi 18 février 2014, 11:06:47 Ross Finlayson a écrit :
> diff --git a/modules/access/live555.cpp b/modules/access/live555.cpp
> index 88ddc2e..6e04a7b 100644
> --- a/modules/access/live555.cpp
> +++ b/modules/access/live555.cpp
> @@ -1091,6 +1091,20 @@ static int SessionsSetup( demux_t *p_demux )
>                  {
>                      tk->fmt.i_codec = VLC_CODEC_VP8;
>                  }
> +                else if( !strcmp( sub->codecName(), "THEORA" ) )
> +                {
> +                    tk->fmt.i_codec = VLC_CODEC_THEORA;
> +                    unsigned int i_extra;
> +                    unsigned char *p_extra;
> +                    if( ( p_extra=parseVorbisConfigStr( sub->fmtp_config(),
> +                                                        i_extra ) ) ) +   
>                 {
> +                        tk->fmt.i_extra = i_extra;
> +                        tk->fmt.p_extra = p_extra;

Considering the other cases, this looks a lot like heap corruption to me. Did 
you actually TEST?

> +                    }
> +                    else
> +                        msg_Warn( p_demux,"Missing or unsupported theora
> header." ); +                }
>              }
>              else if( !strcmp( sub->mediumName(), "text" ) )
>              {

-- 
Реми Денис-Курмон
http://www.remlab.net/