[vlc-devel] [PATCH] swscale: fix warning

[Tristan Matthews]

On Wed, Jun 11, 2014 at 2:49 AM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-06-11 06:58, Tristan Matthews a écrit :
>
>  ---
>>  modules/video_chroma/swscale.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/
>> swscale.c
>> index 7d6faf6..bb8c690 100644
>> --- a/modules/video_chroma/swscale.c
>> +++ b/modules/video_chroma/swscale.c
>> @@ -594,7 +594,7 @@ static void Convert( filter_t *p_filter, struct
>> SwsContext *ctx,
>>      GetPixels( dst, dst_stride, p_dst, i_plane_start, i_plane_count,
>> b_swap_uvo );
>>
>>  #if LIBSWSCALE_VERSION_INT  >= ((0<<16)+(5<<8)+0)
>> -    sws_scale( ctx, src, src_stride, 0, i_height,
>> +    sws_scale( ctx, (const uint8_t * const*) src, src_stride, 0,
>> i_height,
>>                 dst, dst_stride );
>>
>
> Are you sure? That does not seem like a valid cast to me.
>
>
Pretty sure, the warning it silences is:

  In file included from video_chroma/swscale.c:38:0:
  /usr/include/libswscale/swscale.h:213:5: note: expected 'const uint8_t *
const*' but argument is of type 'uint8_t **'

Just found a similar example here:
http://www.ffmpeg.org/doxygen/2.1/scaling__video_8c_source.html

Best,
Tristan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140611/e7b88b3c/attachment.html>