[vlc-devel] [PATCH 01/11] MP4 demux: only set fragmented flag if filecontains movie fragment atoms.

[Matthias Keiser]

Am 20.03.2014 um 06:33 schrieb Francois Cartegnie <fcvlcdev at free.fr>:

> Le 19/03/2014 23:31, Felix Abecassis a écrit :
>> 2014-03-19 23:16 GMT+01:00 Frédéric Yhuel <yhuelf at gmail.com>:
>> 
>>> On Wed, Mar 19, 2014 at 5:53 PM, Frédéric Yhuel <yhuelf at gmail.com> wrote:
>>>> I think the patch should be reverted, because it indeed breaks
>>>> playback of local fMP4 files, as François noticed.
>>> 
>>> Nevermind. Sorry for the noise.
>>> 
>> 
>> Why? I think it does.
>> 
>> See bug https://trac.videolan.org/vlc/ticket/10983
> 
> according to ISO:
> * mvex says there might be *extents*, ie track fragments
>  Then assert using header declarations, or check by scanning.
> * moof says there's *fragments*
> 
> -> Change condition to OR, and pass to avcodec even if we only believe
> it is fragmented (mvex). Whatever the access is.

I am sorry for the confusion I seem to have caused in this thread. All I really can say is that in it's current state, the mp4 demuxer seems to refuse to demux videos recorded with an iPhone, even though it seems perfectly able to do so. I tried to rectify this, but my understanding of the ISO spec was probably a bit too superficial.