[vlc-devel] [PATCH 3/6] src: fix compilation of fourcc_gen on OS/2

Steve Lhomme robux4 at videolabs.io
Wed Jul 22 08:15:13 CEST 2015


By the way, why was fourcc_gen introduced in the first place ? Or can
we just go back to how things were without requiring to build and run
local exe. After all if you're cross-compiling with a C99 compiler,
you should not be required to have a C99 compiler also for your local
environment. For example a buildbot may not run locally compiled code
for security reasons.

On Wed, Jul 22, 2015 at 7:55 AM, KO Myung-Hun <komh78 at gmail.com> wrote:
>
>
> Steve Lhomme wrote:
>> On Wed, Jul 22, 2015 at 4:50 AM, KO Myung-Hun <komh78 at gmail.com> wrote:
>>> Hi/2.
>>>
>>> Rémi Denis-Courmont wrote:
>>>> Le 2015-07-21 11:11, KO Myung-Hun a écrit :
>>>>> The problem is that some systems do not have c99 utility although they
>>>>> have compilers supporting C99.
>>>>
>>>> VLC requires a POSIX environment to build, and always has. In a POSIX
>>>> (2001 or later) environment, "c99" exists. The problem is your setup,
>>>> not VLC.
>>>>
>>>
>>> I don't disagree with you. However, in users' point of view, all users
>>> not having c99 should fix their build environment. In contrast, if VLC
>>> supports that case, it makes all happy.
>>>
>>> In addition, VLC is not checking if c99 works actually.
>>
>> Maybe the right way to test if compiling fourcc_gen works would be to
>> just compile it, run it and see if it works ? That way we could try
>> all sorts of compiler instead of restricting to strict C99 and up.
>>
>
> Of course not. If you read the patch, then you could see that it tested
> simple C99-specific feature.
>
> --
> KO Myung-Hun
>
> Using Mozilla SeaMonkey 2.7.2
> Under OS/2 Warp 4 for Korean with FixPak #15
> In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
>
> Korean OS/2 User Community : http://www.ecomstation.co.kr
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list