[vlc-devel] [PATCH 1/5] mp4: prhd, equi, cbmp and st3d boxes have a flag parameter

[Adrien Maglo]

Le 05/12/2016 à 11:02, Filip Roséen a écrit :
> Hi Adrien,

Hi Filip,

> On 2016-12-05 10:58, Adrien Maglo wrote:
>
>     |According to the Google spatial video specification v2
>     https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md
>     these boxes inherit from "FullBox" which has a flag parameter of 4
>     bytes. This commit fixes the reading of parameters contained in
>     these boxes. --- modules/demux/mp4/libmp4.c | 5 +++++
>     modules/demux/mp4/libmp4.h | 4 ++++ 2 files changed, 9 insertions(+)|
>
> Is there any reason for declaring the /data-members/ as |int32_t|,
> instead of |uint32_t|?

No, good point. I misread the spec.

> Given that I expect, judging from the /data-member name/, that it is to
> contain (bitwise) flags, I would recommend using an /unsigned/ type (as
> this is easier to work with).

I will send an other version.

Thanks,


-- 
MagSoft