[vlc-devel] [PATCH] meta: merge only meta data not previously inserted

[Lukas Solanka]

Hi,

Any suggestions on how to tackle #4143? I had another look at the core and
it looks to me that various demuxers, codecs, etc. contribute to the
metadata, without any particular rules. If the flac file does not contain
any embedded cue sheet this will overwrite any demuxed cue meta added to
the playlist previously.

Thanks,
Lukas

On 22 March 2017 at 22:17, Lukas Solanka <lsolanka at gmail.com> wrote:

> Hi Francois, Jean-Baptiste,
>
> Thanks for the response. Are we talking here about the NowPlaying meta
> field or is this a feature I have missed, like displaying what's being
> played through notifications or so? Sorry if that's a dumb question, just
> trying to understand what you are referring to?
>
> If it's the meta field is this treated somehow special, e.g. certain
> modules always fill this in with the current "Now playing" information when
> it needs to be displayed? Is that done through the vlc_meta_Merge? Again, I
> might be completely missing the point.
>
> If a codec has a different metadata from the demux I believe after the
> patch the first filled meta is retained for the life of the input. Do all
> stages in the processing pipeline share the same p_meta field and
> merge/overwrite their own meta? That's how I understand this by looking
> through the code, so if yes, the very last to merge the meta is always the
> "winner". I didn't see that as a problem, but perhaps you can give me some
> concrete example when this is an issue?
>
> Again, I'm sure you know much better, just trying to understand how to
> deal with the concrete cue+single flac issue.
>
> Thanks,
> Lukas
>
> On 22 March 2017 at 08:57, Francois Cartegnie <fcvlcdev at free.fr> wrote:
>
>> Le 22/03/2017 à 08:48, Jean-Baptiste Kempf a écrit :
>>
>> > But don't you break NowPlaying with this? Or cases where the codec has
>> > different metadata from the demux?
>> >
>>
>> If course it does. It disables the possibility to replace or remove
>> previous metadata.
>>
>>
>> Francois
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170328/438c56ad/attachment.html>