[vlc-devel] [PATCH] qt: fix playlist docked initial status is undefined

[Pierre Lamot]

On 2019-07-29 19:44, Alexandre Janniaux wrote:
> Hi,
> 
> I would have done the opposite, renaming b_plDocked into 
> b_playlistDocked, to
> match the convention in place in the file.

I choosed b_plDocked as it was the historical variable, but no problem.

> Regards,
> --
> Alexandre Janniaux
> VideoLabs
> 
> On Mon, Jul 29, 2019 at 04:58:54PM +0200, Pierre Lamot wrote:
>>   docked state was read from b_playlistDocked while
>>   b_plDocked was read from configuration.
>> ---
>>  modules/gui/qt/main_interface.cpp | 2 +-
>>  modules/gui/qt/main_interface.hpp | 3 +--
>>  2 files changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/modules/gui/qt/main_interface.cpp 
>> b/modules/gui/qt/main_interface.cpp
>> index 6b633dea55..19840eae80 100644
>> --- a/modules/gui/qt/main_interface.cpp
>> +++ b/modules/gui/qt/main_interface.cpp
>> @@ -551,7 +551,7 @@ void MainInterface::setVideoOnTop( bool on_top )
>> 
>>  void MainInterface::setPlaylistDocked( bool docked )
>>  {
>> -    b_playlistDocked = docked;
>> +    b_plDocked = docked;
>> 
>>      emit playlistDockedChanged(docked);
>>  }
>> diff --git a/modules/gui/qt/main_interface.hpp 
>> b/modules/gui/qt/main_interface.hpp
>> index d15a47405d..5562949778 100644
>> --- a/modules/gui/qt/main_interface.hpp
>> +++ b/modules/gui/qt/main_interface.hpp
>> @@ -113,7 +113,7 @@ public:
>>          RAISE_AUDIOVIDEO,
>>      };
>>      bool isInterfaceFullScreen() { return b_interfaceFullScreen; }
>> -    bool isPlaylistDocked() { return b_playlistDocked; }
>> +    bool isPlaylistDocked() { return b_plDocked; }
>>      bool isPlaylistVisible() { return playlistVisible; }
>>      bool isInterfaceAlwaysOnTop() { return b_interfaceOnTop; }
>>      bool hasEmbededVideo() { return m_hasEmbededVideo; }
>> @@ -175,7 +175,6 @@ protected:
>>      bool                 b_videoFullScreen;     ///< --fullscreen
>>      bool                 b_hideAfterCreation;
>>      bool                 b_minimalView;         ///< Minimal video
>> -    bool                 b_playlistDocked;
>>      bool                 b_interfaceFullScreen;
>>      bool                 b_interfaceOnTop;      ///keep UI on top
>>      bool                 b_pauseOnMinimize;
>> --
>> 2.17.1
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel