[vlc-devel] New Serivces Discovery Module for Onvif Cameras

[Jean-Baptiste Kempf]

Hello,

On Sun, 3 Mar 2019, at 13:41, Stephen Rhodes wrote:
> I have developed a services_discovery module for VLC that will find ip cameras on the local network that are onvif compatible using udp broadcast. 

Before going to a review, thanks a lot, this is very useful and requested by users!

>  modification to the Makefile.am is required as well. It has dependency on libxml2 and nettle.

You should use vlc_xml.h header, instead of libxml.

What do you use nettle for?

Best,

> 
> diff --git a/modules/services_discovery/Makefile.am b/modules/services_discovery/Makefile.am
> index efd9cf6..0d6f928 100644
> --- a/modules/services_discovery/Makefile.am
> +++ b/modules/services_discovery/Makefile.am
> @@ -13,6 +13,14 @@ libsap_plugin_la_CFLAGS = $(AM_CFLAGS) $(CFLAGS_sap)
>  libsap_plugin_la_LIBADD = $(LIBS_sap) $(SOCKET_LIBS)
>  sd_LTLIBRARIES += libsap_plugin.la
> 
> +libonvifdisc_plugin_la_SOURCES = services_discovery/onvifdisc.c services_discovery/onvif.c services_discovery/onvif.h
> +libonvifdisc_plugin_la_CFLAGS = $(LIBXML2_CFLAGS) $(NETTLE_CFLAGS)
> +libonvifdisc_plugin_la_LIBADD = $(LIBXML2_LIBS) $(NETTLE_LIBS)
> +sd_LTLIBRARIES += libonvifdisc_plugin.la
> +if HAVE_WIN32
> +libonvifdisc_plugin_la_LIBADD += -liphlpapi
> +endif
> +
>  libavahi_plugin_la_SOURCES = services_discovery/avahi.c
>  libavahi_plugin_la_CFLAGS = $(AM_CFLAGS) $(AVAHI_CFLAGS)
>  libavahi_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(sddir)'
> 
> I'm hoping this module can be added to the official VLC distribution. It has been well tested against a variety of cameras including
> 
> HIKVISION, DAHUA, AXIS, SUNBA, AMCREST, SPECO, TRENDNET, REOLINK, FOSCAM, UTALENT, VIVOTEK, HIKAM
> 
> Thank you for your consideration,
> 
> Stephen Rhodes
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 
> *Attachments:*
>  * onvifdisc.c
>  * onvif.c
>  * onvif.h

--
Jean-Baptiste Kempf - President
+33 672 704 734


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190304/163dcaf4/attachment.html>