[vlc-devel] [PATCH] lib: add libvlc_video_set_spu_text_scale API

[Steve Lhomme]

Ok with float then 

> On 21 Apr 2020, at 14:24, Rémi Denis-Courmont <remi at remlab.net> wrote:
> 
> Hi,
> 
> Fractions are better where fractions are routinely expected, notably aspect and crop ratii. For zoom, I'm not sure anybody uses fractions, but I can live with it.
> 
> The single precision is enough for a pixel accurate ratio though. It's not like we have video formats with more than 16 millions rows or columns.
> 
> Le 21 avril 2020 10:27:49 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>> 
>> On 2020-04-20 20:33, Thomas Guillem wrote:
>> > 
>>> 
>>> On Mon, Apr 20, 2020, at 19:27, Mark Lee wrote:
>>>>  Hi,
>>>> 
>>>>  The --sub-text-scale command-line switch was already an integer in VLC 
>>>>  3.x, and internally uses var_CreateInteger, var_GetInteger and so on.
>>>> 
>>>>  From the review comments so far:
>>>>  - you would prefer float rather than int for the proposed new LibVLC 
>>>>  API method
>>>>  - you do not want to have mismatched float for the LibVLC API and int 
>>>>  for the corresponding VLC command line option
>>>> 
>>>>  So does that mean for this patch to be acceptable you would want it to 
>>>>  include a change to the preexisting --sub-text-scale switch to make 
>>>>  that switch a float instead of an int?
>>> Hello, your last patch is OK for me. I will merge it tomorrow if there 
>>> is no other comments from VLC developers.
>>> 
>>> Bonus: should we change the --sub-text-scale type ? But  this doesn't 
>>> prevent your patch to be merged.
>> 
>> A fraction would be better than an integer or float IMO. This way you 
>> can express precisely in pixels relative to the full video size. I'm not 
>> sure "real" numbers make sense here.
>> 
>> >>
>>>>  Regards,
>>>> 
>>>>  On Mon, 20 Apr 2020 at 14:56, Rémi Denis-Courmont <remi at remlab.net 
>>>>  <mailto:remi at remlab.net>> wrote:
>>>> 
>>>>      Le maanantaina 20. huhtikuuta 2020, 15.34.44 EEST Thomas Guillem a
>>>>      écrit :
>>>>> Hello, thanks for this patch and for responding to our review
>>>> very quickly.
>>>>> I don't have any preferences regarding Integer of float for
>>>> scale. But do we
>>>>> really want to have float for libvlc and int for vlc command
>>>>      line options ?
>>>> 
>>>>      Of course not. We use float everywhere except UI, e.g. --rate or
>>>>      --zoom.
>>>> 
>>>> 
>>>>      -- 
>>>>      雷米‧德尼-库尔蒙
>>>>      http://www.remlab.net/
>>>>      Rémi Denis-Courmont
>>>>      vlc-devel mailing list
>>>>      To unsubscribe or modify your subscription options:
>>>>      https://mailman.videolan.org/listinfo/vlc-devel
>>>>  vlc-devel mailing list
>>>>  To unsubscribe or modify your subscription options:
>>>>  https://mailman.videolan.org/listinfo/vlc-devel
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté._______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200422/ca66e66f/attachment.html>