[vlc-devel] [PATCH] contrib: sidplay2: fix signed char stored as int8_t

Martin Storsjö martin at martin.st
Thu Jan 9 13:06:42 CET 2020


On Thu, 9 Jan 2020, Rémi Denis-Courmont wrote:

> Hi,
> 
> Narrowing is not an error. And the patch does not even fix the narrowing
> problem on platforms with signed 'char' such as x86. Looks like some bad
> -Werror here.

This particular error actually is enabled by GCC automatically for C++ 
code, when targeting C++11 (iirc) or newer, without the user explicitly 
setting -Werror.

// Martin


More information about the vlc-devel mailing list