[vlc-devel] [PATCH v4 00/20] Add support for OpenGL filters

[Alexandre Janniaux]

Hi,

Patchset LGTM,

I'll post a detailed version of the expected architecture
and building blocks for OpenGL filters in order to provide
answers to the remarks that have been made on previous
patchsets.

Regards,
--
Alexandre Janniaux
Videolabs


On Tue, Jul 07, 2020 at 12:33:43PM +0200, Romain Vimont wrote:
> Previous versions:
> v1: https://mailman.videolan.org/pipermail/vlc-devel/2020-June/134800.html
> v2: https://mailman.videolan.org/pipermail/vlc-devel/2020-July/134960.html
> v3: https://mailman.videolan.org/pipermail/vlc-devel/2020-July/135096.html
>
> Here is a version without the --gl-filter option nor the mock filter.
> The mock filter will be submitted after the OpenGL filter_t implementation is
> merged.
>
> Changes from v3:
>  - remove --gl-filter CLI option (remove patch 8 from v2)
>  - remove mock filter (remove patch 22 from v2)
>  - adapt documentation not to refer to the mock filter (patch 20)
>
> Romain Vimont (20):
>   opengl: introduce OpenGL filter API
>   opengl: add filter private part
>   opengl: add filters chain
>   opengl: use modules for OpenGL filters
>   opengl: store video format in sampler
>   opengl: add "direct" sampler
>   opengl: attach samplers to filters
>   opengl: pass output size to filters
>   opengl: add support for renderbuffers API
>   opengl: create and bind filters framebuffers
>   opengl: use default draw framebuffer
>   opengl: add "draw" filter
>   opengl: support "blend" filters
>   opengl: lazy-load sampler
>   opengl: apply viewport on filters
>   opengl: pass picture date to filters
>   opengl: add support for renderbuffers API
>   opengl: init filters framebuffers in a second pass
>   opengl: enable multisampling
>   opengl: document filters implementation
>
>  modules/video_output/caopengllayer.m       |   5 +
>  modules/video_output/ios.m                 |   5 +
>  modules/video_output/macosx.m              |   5 +
>  modules/video_output/opengl/Makefile.am    |   8 +
>  modules/video_output/opengl/display.c      |   6 +
>  modules/video_output/opengl/filter.c       | 128 +++++
>  modules/video_output/opengl/filter.h       | 115 +++++
>  modules/video_output/opengl/filter_draw.c  | 181 +++++++
>  modules/video_output/opengl/filter_draw.h  |  36 ++
>  modules/video_output/opengl/filter_priv.h  |  83 ++++
>  modules/video_output/opengl/filters.c      | 549 +++++++++++++++++++++
>  modules/video_output/opengl/filters.h      | 109 ++++
>  modules/video_output/opengl/gl_api.c       |  23 +
>  modules/video_output/opengl/gl_api.h       |   3 +
>  modules/video_output/opengl/gl_common.h    |  35 ++
>  modules/video_output/opengl/renderer.c     |  95 ++--
>  modules/video_output/opengl/renderer.h     |  38 +-
>  modules/video_output/opengl/sampler.c      | 111 ++++-
>  modules/video_output/opengl/sampler.h      |   2 +-
>  modules/video_output/opengl/sampler_priv.h |  42 +-
>  modules/video_output/opengl/vout_helper.c  |  50 +-
>  modules/video_output/win32/glwin32.c       |   5 +
>  22 files changed, 1540 insertions(+), 94 deletions(-)
>  create mode 100644 modules/video_output/opengl/filter.c
>  create mode 100644 modules/video_output/opengl/filter.h
>  create mode 100644 modules/video_output/opengl/filter_draw.c
>  create mode 100644 modules/video_output/opengl/filter_draw.h
>  create mode 100644 modules/video_output/opengl/filter_priv.h
>  create mode 100644 modules/video_output/opengl/filters.c
>  create mode 100644 modules/video_output/opengl/filters.h
>
> --
> 2.27.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel