[vlc-devel] [PATCH] test: use long sleep instead of pause

Marvin Scholz epirat07 at gmail.com
Sat Jul 18 11:00:01 CEST 2020


On 17 Jul 2020, at 15:49, Rémi Denis-Courmont wrote:

> sleep() is not portably thread-safe and we specifically want to check 
> without
> time-out.
>

Hi, thanks for the review.
Why is it not thread-safe? I checked what POSIX says about it and it 
seemed
safe to use here. Would something like nanosleep be better?

And yes, while we want to wait indefinitely I did not find any other 
function
that would work for that case? And as long as we wait longer than the 
test
timeout, it should be fine, no?

Do you have any other idea how to solve this? It would be really really 
nice
to have the test suite working on macOS and apart from the TLS test, 
this
is the only one still failing now.

> -2
>
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list