[vlc-devel] [PATCH v2 00/26] filter close callback in operations structure

[Steve Lhomme]

On 2020-10-12 10:29, Alexandre Janniaux wrote:
> Hi,
> 
> On Mon, Oct 12, 2020 at 09:27:54AM +0200, Steve Lhomme wrote:
>> On 2020-10-11 10:11, Rémi Denis-Courmont wrote:
>>> Le perjantaina 9. lokakuuta 2020, 16.03.56 EEST Steve Lhomme a écrit :
>>>> This patchset sits on top of previously submited patches. The resulting
>>>> branch can be found at :
>>>> https://code.videolan.org/robUx4/vlc/-/tree/filters/close-cb/0
>>>>
>>>> Changes since v1:
>>>> - add the rest of the filters, including audio ones
>>>> - add a close callback for generated video filter code that also generates
>>>>     the operations structure.
>>>> - leverages previous patches like the code generator in more filters
>>>> - add the Close callback after the flush where the flush has been added
>>>
>>> Are there any filters using deactivate after this? If not, you could replace
>>> the module_unneed() calls.
>>
>> If there are, it's a mistake on my side.
>> I'll have a look.
> 
> Please note that if you remove the module_unneed, you also
> need to re-add the objres_clean call, hence why I kept it
> in the patchset I gave to you.

In the end I prefer not to. It also does

     msg_Dbg(obj, "removing module \"%s\"", module_get_object(module));
     var_Destroy(obj, "module-name");

Which is very useful for debugging. Or maybe there should be a 
vlc_objres_clear that does this log. Or maybe it should also be done in 
there ?