[vlc-devel] [PATCH] qt: fix missed opportunity to use translation wrappers

[Lyndon Brown]

simplification. there's no reason for these two cases to not use qtr() rather than qfu() with explicit vlc_gettext().

patch attached. preview:

diff --git a/modules/gui/qt/dialogs/dialogs_provider.cpp b/modules/gui/qt/dialogs/dialogs_provider.cpp
index 72a96946d3..e565a84cb9 100644
--- a/modules/gui/qt/dialogs/dialogs_provider.cpp
+++ b/modules/gui/qt/dialogs/dialogs_provider.cpp
@@ -621,7 +621,7 @@ void DialogsProvider::savePlayingToPlaylist()
 
     for( size_t i = 0; i < sizeof (types) / sizeof (types[0]); i++ )
     {
-        QString tmp = qfu( vlc_gettext( types[i].filter_name ) ) + " (*." + types[i].filter_patterns + ")";
+        QString tmp = qtr( types[i].filter_name ) + " (*." + types[i].filter_patterns + ")";
         if( ext == qfu( types[i].filter_patterns ) )
             filters.insert( 0, tmp );
         else
@@ -655,7 +655,7 @@ void DialogsProvider::savePlayingToPlaylist()
     {
         for( size_t i = 0; i < sizeof (types) / sizeof (types[0]); i++)
         {
-            if ( selected.startsWith( qfu( vlc_gettext( types[i].filter_name ) ) ) )
+            if ( selected.startsWith( qtr( types[i].filter_name ) ) )
             {
                 psz_selected_module = types[i].module;
                 psz_last_playlist_ext = types[i].filter_patterns;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qt_tw.patch
Type: text/x-patch
Size: 1347 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200923/de53d4ee/attachment.bin>