<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.14.1">
</HEAD>
<BODY>
Hi,<BR>
<BR>
I removed all the warnings for jack.c .<BR>
<BR>
Also by Rémi Denis-Courmont comments, I changed the way I find the power of 2 not to use <math.h>. <BR>
<BR>
Le jeudi 30 août 2007 à 23:42 +0200, Christophe Mutricy a écrit :
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">Hello,</FONT>
<FONT COLOR="#000000">On Thu, Aug 30, 07 at 09:14 -0400, Pierre-Luc Beaudoin wrote:</FONT>
<FONT COLOR="#000000">> As per Christophe Mutricy request, I splitted my patch.</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> This part covers Jack Input bugfixes and some more options:</FONT>
<FONT COLOR="#000000">> - bug: cracking in the captured sound</FONT>
<FONT COLOR="#000000">> - autoconnect to inputs</FONT>
<FONT COLOR="#000000">> - use VLC pace</FONT>
<FONT COLOR="#000000">Even after adding unistd.h, it doesn't compiles cleanly here:</FONT>
<FONT COLOR="#000000">../../../modules/access/jack.c: In function 'Process':</FONT>
<FONT COLOR="#000000">WARNING : ../../../modules/access/jack.c: 428: passing argument 2 of</FONT>
<FONT COLOR="#000000">'jack_ringbuffer_write' from incompatible pointer type</FONT>
<FONT COLOR="#000000">../../../modules/access/jack.c: In function 'GrabJack':</FONT>
<FONT COLOR="#000000">WARNING : ../../../modules/access/jack.c: 473: pointer targets in</FONT>
<FONT COLOR="#000000">passing argument 2 of 'jack_ringbuffer_read' differ in signedness</FONT>
<FONT COLOR="#000000">../../../modules/access/jack.c: In function 'Port_finder':</FONT>
<FONT COLOR="#000000">WARNING : ../../../modules/access/jack.c: 527: assignment discards</FONT>
<FONT COLOR="#000000">qualifiers from pointer target type</FONT>
<FONT COLOR="#000000">Not sure if they are all caused by your patch, but it should be fixed</FONT>
<FONT COLOR="#000000">before commit.</FONT>
<FONT COLOR="#000000">Regards,</FONT>
</PRE>
</BLOCKQUOTE>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
--<BR>
<B>Pierre-Luc Beaudoin</B><BR>
Savoir-faire Linux<BR>
<BR>
<BR>
</TD>
</TR>
</TABLE>
</BODY>
</HTML>