<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div>On Apr 19, 2008, at 5:12 PM, Rémi Denis-Courmont wrote:<br><blockquote type="cite">Le Saturday 19 April 2008 04:22:05 git version control, vous avez écrit :<br><blockquote type="cite">vlc | branch: master | Pierre d'Herbemont <<a href="mailto:pdherbemont@videolan.org">pdherbemont@videolan.org</a>> | Sat<br></blockquote><blockquote type="cite">Apr 19 02:51:42 2008 +0200| [b66dfd1b9f7587822fd5c8ad7b6d153d72b889c5]<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">test: Test meta data support.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Note, this is done even if no meta data module is compiled. A future commit<br></blockquote><blockquote type="cite">should fix that.<br></blockquote><br>This is _not_ specific to this commit (I mean, the problem was already there <br>before), but I really don't like "make check" and "make distcheck" to depend <br>on a working Internet connection. IMHO, if some files are needed, they ought <br>to be in the tarball (and, yeah, that means small).</blockquote></div><div><br></div><div>`make distcheck` is broken if there is no internet connection for sure. I know that some of us doesn't agree to put some samples in the source git tree. It does also make sense I think.</div><div><br></div><div>Currently the proposition is to put core samples (basically a video and a file with meta data) that don't exceed 500Ko in some place in the tree.</div><div><br></div><div>I do propose to create a new git-submodule that would hold the samples files needed. Hence we'll keep a separation between sources and samples.</div><div><br></div><div>Basically that mean, we create a samples.git in git.v.o and add:</div><div><div><div><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;">[submodule "samples"]</span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;"><span class="Apple-tab-span" style="white-space:pre"> </span>path = test/samples</span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;"><span class="Apple-tab-span" style="white-space:pre"> </span>url = git://git.videolan.org/samples.git</span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;"><br></span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;">to vlc/.gitmodules</span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;"><br></span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;">Is that solution more appropriate and fulfill both concern?</span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;"><br></span></font></pre><pre><font class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" style="font-size: 12px; white-space: normal;">Pierre.</span></font></pre></div></div><br></div></body></html>