<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 9pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'><BR><BR><BR><BR><BR>
<HR id=stopSpelling>
<BR>
> Date: Thu, 22 May 2008 21:01:14 -0700<BR>> From: jb@videolan.org<BR>> To: vlc-devel@videolan.org<BR>> Subject: Re: [vlc-devel] [PATCH] RealVideo Support<BR>> <BR>> Hello,<BR>> <BR>> I just have a few random questions, and many of them are cosmetic. :D<BR>
<BR>
my pleasure. :)<BR><BR>> <BR>> - Can you split the rstp part and the realvideo part or are they linked<BR>> too much ? Same for the realvideo decoder and the demuxer<BR>> modifications...<BR>
<BR>
yes, i can split the patch to 3 part.<BR>
<BR>> <BR>> - Why do you remove the AC_CHECK_FUNCS on uselocale ?<BR>
<BR>
configure.ac ?<BR>
since i do the work in 0.8.6, maybe it is problem when i switch to git version.<BR>
<BR>> <BR>> - Why is RtspReadAndSkip( ) returning int if you never check the return<BR>> value and always return 0 ? Why not void ?<BR>
<BR>
design but not impliment, maybe it should return some bytes which skipped.<BR>
but in fact the bytes is meaningless.<BR>
<BR>> <BR>> - I think that<BR>> > + if( psz ) free( psz );<BR>> can be used as free( psz ) in vlc. So, the modifications on that are<BR>> useless... This was discussed on this mailing list before, IIRC.<BR>> <BR>
<BR>
o, i don't know and not sure. maybe i can remove the useless if.<BR>
<BR>
<BR>> - Why removing intf_UserFatal ? (this might be a good idea, btw)<BR>
<BR>
don't know more about intf_UserFatal. ...<BR>
<BR>
<BR>> <BR>> - Why removing case ACCESS_GET_CONTENT_TYPE: ?<BR>
<BR>
maybe it be add in new git version.<BR>
i will add it<BR>
<BR>> <BR>> - Some changes in rtsp/real.c are just adding trailing spaces on the<BR>> lines. Please remove those.<BR>> <BR>> - Why this change :<BR>> > - ptr1=(uint8_t*)(key+16);<BR>> > - ptr2=(uint8_t*)(key+20);<BR>> > + ptr1=(key+16);<BR>> > + ptr2=(key+20);<BR>> <BR>> Same for this one:<BR>> > - rtsp_send_ok( rtsp_session );<BR>> > - free( challenge1 );<BR>> > - free( alert );<BR>> > - free( buf );<BR>> > + rtsp_send_ok(rtsp_session);<BR>> > + if( challenge1 ) free(challenge1);<BR>> > + if( alert ) free(alert);<BR>> > + if( buf ) free(buf);<BR>> <BR>> And that one ?<BR>> > - if( rtsp_read_data(rtsp_session, (uint8_t*)description, size) <= 0)<BR>> > + if( rtsp_read_data(rtsp_session, description, size) <= 0)<BR>
<BR>
(uint8_t*) maybe is added in git version... my original code a little old.<BR>
<BR>> <BR>> Or that one (cosmetic) ?<BR>> > - desc->stream = malloc(sizeof(sdpplin_stream_t*)*desc->stream_count);<BR>> > - handled=1;<BR>> > - data=nl(data);<BR>> > + desc->stream = malloc(sizeof(sdpplin_stream_t*)*desc->stream_count);<BR>> > + handled=1;<BR>> > + data=nl(data);<BR>> <BR>> - On realvideo.c there is a realaudio.c header. Copyright dates are<BR>> wrong.<BR>
<BR>
yes.<BR>
<BR>> <BR>> - on that part, you should look at the realaudio.c file, because it<BR>> looks in more parts, but that is a detail.<BR>> > +#ifdef WIN32<BR>> > +const char *g_decode_path="plugins\\drv43260.dll";<BR>> > +#else<BR>> > +const char *g_decode_path="../lib/vlc/codec/drv4.so.6.0";<BR>> > +#endif<BR>> <BR>> - Check mallocs ?<BR>> > + decoder_sys_t *p_sys = malloc( sizeof( decoder_sys_t ) );<BR>
ok<BR>
<BR>> <BR>> - I think you add unnecessary includes in your patch (stdlib, for<BR>> example)<BR>> - +#if 1 ?<BR>> <BR>> - Please comment in english...<BR>> > + // ����ʹ��Stream��position������ʹ��frame��druationӦ�ø�����<BR>> <BR>> - You have many commented lines that you add, why ?<BR>
ok, because the patch not perfect , so i record some comments/codes for futures<BR>
improve. maybe i need clean it.<BR>
<BR>> <BR>> This was just randomed questions, I may be wrong, too...<BR>> <BR>> This patch is looking like an old patch here that was never included<BR>> because it wasn't clean enough IIRC, and that I was unable to make work<BR>> on linux... If we can make it that would be great.... :D<BR>
<BR>
yes, the realvideo's patch is coming from it, and i do improve about rtsp, demux, etc.<BR>
<BR>> <BR>> Thanks a lot for the work.<BR>
<BR>
ok, i will review the code and submit again, hehe .<BR>
i must agree, i an not too professional as a programmer. :(<BR>
<BR>
-- <BR>
wangbo<BR>
<BR>> <BR>> <BR>> Best Regards,<BR>> <BR>> -- <BR>> Jean-Baptiste Kempf<BR>> http://www.jbkempf.com/<BR><BR><br /><hr />Windows Live Writer，支持离线撰写博客内容，随时随地想写就写。 <a href='http://get.live.cn/product/writer.html' target='_new'>立即使用！</a></body>
</html>