<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
attached with fixes.<br>
<br>
Pierre d'Herbemont wrote:
<blockquote
cite="mid:e761307d0809210323m4a121d79va733542828fec45d@mail.gmail.com"
type="cite">
<pre wrap="">Thanks Dylan,
Some small comments on minor issues (a simple git commit -a -m "small
modif" and git rebase -i will easily merge you those modification
requests).
</pre>
<blockquote type="cite">
<pre wrap=""> msg_Err(p_access,"I am the Timeshifter!");
</pre>
</blockquote>
<pre wrap=""><!---->
There are a lot of msg_Err() like thise one that should now be msg_Dbg().
</pre>
<blockquote type="cite">
<pre wrap=""> //should be enomem
return VLC_EGENERIC;
</pre>
</blockquote>
<pre wrap=""><!---->
Why that?
</pre>
<blockquote type="cite">
<pre wrap=""> for( i = 0;i < p_sys->i_files;i++)
for( i = 0; i < p_sys->i_files; i++ )
</pre>
</blockquote>
<pre wrap=""><!---->
Spacing are not consistents here.
Same here:
</pre>
<blockquote type="cite">
<pre wrap="">+ }
}
+ msleep(150);
+
+ //msg_Err(p_access,"crit");
+ int i;
+ /* If FIFO empty AND no data left, try slow down the input*/
+ if((block_FifoSize( p_sys->p_fifo) < TIMESHIFT_FIFO_CRITICAL) &&
+ (p_sys->i_current_read == p_sys->i_current_write) &&
+ !p_access->b_die)
+ {
</pre>
</blockquote>
<pre wrap=""><!---->
</pre>
<blockquote type="cite">
<pre wrap="">+ input_thread_t *p_input = vlc_object_find( p_access, VLC_OBJECT_INPUT, FIND_ANYWHERE );
</pre>
</blockquote>
<pre wrap=""><!---->
This should be FIND_PARENT, I think. vlc_object_find is now deprecated
but I guess you don't have much alternative for the moment.
+ //p_sys->i_rate_adjustment =
There are a lot of commented code. What about removing them, or
hinting on why they are here?
That's all for my quite superficial review :)
Pierre.
On Sun, Sep 21, 2008 at 11:35 AM, Dylan Yudaken <a class="moz-txt-link-rfc2396E" href="mailto:dyudaken@gmail.com"><dyudaken@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi everyone,
here is the patch for the timeshift module rewrite I did for the google
summer of code.
its quite a lot more stable (if you fast forward past the end it doesnt
break completely), and could be able to seek in certain situations.
The other part of my project ( a lot bigger ) will take some work to get
ready for submission
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="http://mailman.videolan.org/listinfo/vlc-devel">http://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
</blockquote>
<pre wrap=""><!---->_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="http://mailman.videolan.org/listinfo/vlc-devel">http://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
</blockquote>
</body>
</html>