<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Jean-Baptiste Kempf wrote:
<blockquote cite="mid:20090404101329.GA5277@videolan.org" type="cite">
<pre wrap="">On Sat, Apr 04, 2009 at 08:28:37PM +1100, xxcv wrote :
</pre>
<blockquote type="cite">
<pre wrap="">git version control wrote:
</pre>
<blockquote type="cite">
<pre wrap="">vlc | branch: master | David Flynn <a class="moz-txt-link-rfc2396E" href="mailto:davidf@rd.bbc.co.uk"><davidf@rd.bbc.co.uk></a> | Wed Apr 1
21:40:02 2009 +0000| [151982aab503fa812cd4d6e830df34e78871c106] |
committer: Jean-Baptiste Kempf
win32: fix %zu fixups - dont use mingw's vsnprintf
Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
to 'aid' portability/standards compliance, mingw provide a
static version of [v]snprintf that is buggy.
The bug manifests as %lx is treated as a 64bit argument not
32bit, ie consumes two 32bit parameters. if a %s were to
follow a %lx, bad things can happen.
Solution: Be sure to use the MSVCRT version, at least it
behaves as expected
Additionally, make it a bit more obvious when vlc wrappers
are being called by other wrappers.
Signed-off-by: David Flynn <a class="moz-txt-link-rfc2396E" href="mailto:davidf@rd.bbc.co.uk"><davidf@rd.bbc.co.uk></a>
Signed-off-by: Jean-Baptiste Kempf <a class="moz-txt-link-rfc2396E" href="mailto:jb@videolan.org"><jb@videolan.org></a>
</pre>
</blockquote>
<pre wrap="">Did anybody else tested these patches before you signed them off and commit?
</pre>
</blockquote>
<pre wrap=""><!---->
I tested them and linkfanel did on WinCE.
</pre>
<blockquote type="cite">
<pre wrap="">Because I just found out it crashes when loading wmv / asf files... #2629
</pre>
</blockquote>
<pre wrap=""><!---->
Are you sure you are not hitting the WMA/SSE bug from avcodec because my
latest contrib picked a wrong version of avcodec?
To be sure, try to deactivate SSE/SSE2 in VLC prefs and restart it.
Best random Regards,
</pre>
</blockquote>
I am going to revert these 4 patches from David ..and retest.<br>
Pretty sure these patches caused the problem.. because the binary that
I compiled<br>
from yesterday works fine with wmv since fenrir fixed dmo wrappers. And<br>
there wasn't too many commits or important commits which would affect
wmv playback<br>
and the most suspicious commits are these four.<br>
<br>
Regards.<br>
<br>
<br>
</body>
</html>