<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7654.12">
<TITLE>RE: [vlc-devel] [PATCH] Enable aspectratio parameter in mozillaplugin</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>On Wed, Jun 10, 2009 at 1:29 PM, Vicente Jiménez<googuy@gmail.com> wrote:<BR>
> Thanks for the review!<BR>
><BR>
> I've suposed it was C++ code because of the file extension. I was<BR>
> looking for similar parameter operations in the code but found none<BR>
> and I supposed that the concatenation could be done with +. Thanks for<BR>
> the clarifications.<BR>
><BR>
> You mean to do:<BR>
> ppsz_argv[ppsz_argc++] = "--aspect-ratio";<BR>
> ppsz_argv[ppsz_argc++] = argv[i];<BR>
><BR>
> Is this correct?<BR>
><BR>
No it isn't correct. This patch opens a can of worms.<BR>
<BR>
The mozilla plugin has already support for specifying an aspect ration (vlc.video.aspectRatio). Please read the documentation on <A HREF="http://wiki.videolan.org/Documentation:WebPlugin#Building_HTML_pages_for_Mozilla.2FFirefox.2FInternet_Explorer.2FSafari">http://wiki.videolan.org/Documentation:WebPlugin#Building_HTML_pages_for_Mozilla.2FFirefox.2FInternet_Explorer.2FSafari</A>.<BR>
<BR>
gtz,<BR>
Jean-Paul Saman.</FONT>
</P>
</BODY>
</HTML>