<div>On Sun, Jan 24, 2010 at 10:46 AM, Rafaël Carré <span dir="ltr"><<a href="mailto:rafael.carre@gmail.com">rafael.carre@gmail.com</a>></span> wrote:<br></div>
<div class="gmail_quote">
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">On Sat, 23 Jan 2010 21:51:40 -0500<br>
<div class="im">Robert Krakora <<a href="mailto:rob.krakora@messagenetsystems.com">rob.krakora@messagenetsystems.com</a>> wrote:<br><br></div>
<div class="im">> The patch looks good. I have had it running on over 100 Linux-based<br>> mediaports since I came up with it in September and have seen no<br>> reoccurance of the memory leak.<br><br></div>I can't review the patch but here some remarks made on irc:<br>
<br>19:37 < nefrir> mmh the code style is wrong (ie not consistant)<br>19:37 < funman> also the for (i=-1...) looks weird<br>19:39 < nefrir> and the patch protects only against audio missing I<br>think<br>
19:39 < nefrir> (his use case)<br>19:40 < j-b> beurk at the patch then<br><br>JPsaman could you have a look at it ?<br><br><br>--<br><font color="#888888">Rafaël Carré<br></font><br>_______________________________________________<br>
vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote>
</div>
<div>Hello,</div>
<div> </div>
<div>Yes, the memory leak bug came into play originally when audio was missing and that is what was patched. It should also work if video is missing. The rest of the services need to be patched as well. However, it seemed to me that audio and video services were the only services referenced by the file. Yes, I did create the patch to cover my use case as it makes use of only video and audio services. I would encourage someone with more VLC knowledge than myself to revise/rewrite the patch or re-architect the module correctly. I appreciate <font color="#000000">Rafaël for bringing attention to this issue as I would like this bug to be fixed correctly. ;-)</font></div>
<div> </div>
<div>Best Regards,<br clear="all"><br>-- <br>Rob Krakora<br>Senior Software Engineer<br>MessageNet Systems<br>101 East Carmel Dr. Suite 105<br>Carmel, IN 46032<br>(317)566-1677 Ext. 206<br>(317)663-0808 Fax<br></div>