<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:st1="urn:schemas-microsoft-com:office:smarttags" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]--><o:SmartTagType
namespaceuri="urn:schemas-microsoft-com:office:smarttags" name="PostalCode"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="State"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="Street"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="address"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="place"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="City"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="PersonName"/>
<!--[if !mso]>
<style>
st1\:*{behavior:url(#default#ieooui) }
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Is it the same memory leak problem as in the
ts <b><span style='font-weight:bold'>demux</span></b> without audio?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<div>
<p class=MsoNormal><st1:PersonName w:st="on"><font size=2 color=navy
face=Arial><span style='font-size:10.0pt;font-family:Arial;color:navy'>Yair
Han</span></font></st1:PersonName><font color=navy><span style='color:navy'><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Software Engineer</span></font><font
color=navy><span style='color:navy'><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>EZTV Client Team Leader</span></font><font
color=navy><span style='color:navy'><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Optibase Ltd.</span></font><font
color=navy><span style='color:navy'><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Tel: +972-9-9709259</span></font><font
color=navy><span style='color:navy'><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><a href="mailto:yairh@optibase.com">yairh@optibase.com</a></span></font><font
color=navy><span style='color:navy'> </span></font><o:p></o:p></p>
</div>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
vlc-devel-bounces@videolan.org [mailto:vlc-devel-bounces@videolan.org] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Robert Krakora<br>
<b><span style='font-weight:bold'>Sent:</span></b> Sunday, January 24, 2010
8:33 PM<br>
<b><span style='font-weight:bold'>To:</span></b> Mailing list for VLC media
player developers<br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [vlc-devel] [PATCH]
Fix-for-TS-Muxer-memory-leak (Part II)</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>On Sun, Jan 24, 2010 at 10:46 AM, Rafaël Carré <<a
href="mailto:rafael.carre@gmail.com">rafael.carre@gmail.com</a>> wrote:<o:p></o:p></span></font></p>
</div>
<div>
<blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;
margin-left:4.8pt;margin-right:0in'>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>On Sat, 23 Jan 2010 21:51:40 -0500<o:p></o:p></span></font></p>
<div>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Robert Krakora <<a
href="mailto:rob.krakora@messagenetsystems.com">rob.krakora@messagenetsystems.com</a>>
wrote:<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>> The patch looks
good. I have had it running on over 100 Linux-based<br>
> mediaports since I came up with it in September and have seen no<br>
> reoccurance of the memory leak.<o:p></o:p></span></font></p>
</div>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>I can't review the patch
but here some remarks made on irc:<br>
<br>
19:37 < nefrir> mmh the code style is wrong (ie not consistant)<br>
19:37 < funman> also the for (i=-1...) looks weird<br>
19:39 < nefrir> and the patch protects only against audio missing I<br>
think<br>
19:39 < nefrir> (his use case)<br>
19:40 < j-b> beurk at the patch then<br>
<br>
JPsaman could you have a look at it ?<br>
<br>
<br>
--<br>
<font color="#888888"><span style='color:#888888'>Rafaël Carré<br>
</span></font><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><o:p></o:p></span></font></p>
</blockquote>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Hello,<o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Yes, the memory leak bug came into play originally when audio was
missing and that is what was patched. It should also work if video is
missing. The rest of the services need to be patched as well.
However, it seemed to me that audio and video services were the only services
referenced by the file. Yes, I did create the patch to cover my use case
as it makes use of only video and audio services. I would encourage
someone with more VLC knowledge than myself to revise/rewrite the patch or
re-architect the module correctly. I appreciate <font color=black><span
style='color:black'>Rafaël for bringing attention to this issue as I would like
this bug to be fixed correctly. ;-)</span></font><o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>Best Regards,<br clear=all>
<br>
-- <br>
Rob Krakora<br>
Senior Software Engineer<br>
MessageNet Systems<br>
<st1:Street w:st="on"><st1:address w:st="on">101 East Carmel Dr. Suite 105</st1:address></st1:Street><br>
<st1:place w:st="on"><st1:City w:st="on">Carmel</st1:City>, <st1:State w:st="on">IN</st1:State>
<st1:PostalCode w:st="on">46032</st1:PostalCode></st1:place><br>
(317)566-1677 Ext. 206<br>
(317)663-0808 Fax<o:p></o:p></span></font></p>
</div>
</div>
</body>
</html>