Hi, Austin,<br><br>Please keep formatting and cosmetic changes apart from those which introduce new code behavior - in different patches - so it is easier to evaluate it.<br><br>On Wed, Jun 9, 2010 at 3:04 AM, Austin Burrow <span dir="ltr"><<a href="mailto:atburrow@gmail.com">atburrow@gmail.com</a>></span>
wrote:<br><blockquote style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;" class="gmail_quote">+ if ( _p_contents )<br>
+ {<br>
+ delete _p_contents;<br>
+ services_discovery_RemoveItem( _p_sd, _p_input_item );<br>
+ services_discovery_AddItem( _p_sd, _p_input_item, NULL );<br>
+ }<br></blockquote>
<br>If I get it right, you are rebuilding the whole item tree from top, right? Since created input items seem to be stored in the plugin ( p_container->setInputItem( p_input_item ) ), it seems to me that it allows for a better approach which would compare new and old items and only add/remove changes, even if the upnp server posts the whole list every time.<br>