How are these patches?<br><br>Ronald Wright<br><br><div class="gmail_quote">2010/6/21 Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:rem@videolan.org">rem@videolan.org</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hello,<br>
<div class="im"><br>
On Monday 21 June 2010 02:42:21 Ron Wright, you wrote:<br>
> I have ported the SC4 compressor from LADSPA SWH to VLC and posted the<br>
> preview of the necessary patch in one of the forums. Attached is the patch<br>
> that j-b requested me to post here.<br>
<br>
</div>The code looks quite good to me!<br>
<br>
There are just a few nits:<br>
- git format patch not used,<br>
- UI part should be a separate patch,<br>
- a few trailing white spaces.<br>
<br>
Best regards,<br>
<br>
--<br>
<font color="#888888">Rémi Denis-Courmont<br>
</font></blockquote></div><br>