<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Pankaj yadav</b> <span dir="ltr"><<a href="mailto:pankajdnapster@gmail.com">pankajdnapster@gmail.com</a>></span><br>
Date: 2010/7/29<br>Subject: Re: [vlc-devel] [Patch] Symbian Merge__Changes to /src/bin<br>To: Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>><br><br><br>Rectified<br><br><div class="gmail_quote">
2010/7/29 Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span><div><div></div><div class="h5"><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

diff --git a/bin/vlc.c b/bin/vlc.c<br>
index c8a05ba..81ca99e 100644<br>
--- a/bin/vlc.c<br>
+++ b/bin/vlc.c<br>
@@ -44,6 +44,18 @@<br>
 #include <string.h><br>
 #endif<br>
<br>
+#ifdef SYMBIAN<br>
+#include <vlc_common.h><br>
+static vlc_mutex_t exit_lock = VLC_STATIC_MUTEX;<br>
+static vlc_cond_t  exiting = VLC_STATIC_COND;<br>
+void symbian_libvlc_Wait( libvlc_int_t *p_libvlc );<br>
<br>
You probably don't need that line ^^.<br>
You could simply mark the function as 'static'.<br>
<br>
+void symbian_libvlc_Wait( libvlc_int_t *p_libvlc )<br>
+{<br>
+    vlc_mutex_lock( &exit_lock );<br>
+    vlc_cond_wait( &exiting, &exit_lock );<br>
+    vlc_mutex_unlock( &exit_lock );<br>
+}<br>
+#endif<br>
<br>
Using a semaphore would be a lot simpler or more correct:<br>
        sem_wait( &exit_sem );<br>
here and:<br>
        sem_post( &exit_sem );<br>
in vlc_kill(). Normally, a condition variable must always have some external<br>
state, whereas a semaphore has its own internal state.<br>
<font color="#888888"><br>
<br>
--<br>
Rémi Denis-Courmont<br>
<a href="http://www.remlab.net/" target="_blank">http://www.remlab.net/</a><br>
<a href="http://fi.linkedin.com/in/remidenis" target="_blank">http://fi.linkedin.com/in/remidenis</a><br>
</font></blockquote></div></div></div><br><br clear="all"><div><div></div><div class="h5"><br>-- <br>Pankaj Yadav<br><br>Open Source Enthusiast<br>
</div></div></div><br><br clear="all"><br>-- <br>Pankaj Yadav<br><br>Open Source Enthusiast<br>