<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div><br><div><div>On 21. des. 2010, at 22.12, Pierre d'Herbemont wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div bgcolor="#FFFFFF"><div><br>Hello Rune,</div><div><br>El 20/12/2010, a las 16:14, Rune Botten <<a href="mailto:rbotten@gmail.com">rbotten@gmail.com</a>> escribiσ:<br><br></div><div></div><blockquote type="cite"><div><span>---</span><br><span> .../macosx/framework/Headers/Public/VLCMedia.h | 12 ++++++--</span><br><span> projects/macosx/framework/Sources/VLCMedia.m | 30 +++++++++++++++++++-</span><br><span> 2 files changed, 38 insertions(+), 4 deletions(-)</span><br><span></span><br><span>diff --git a/projects/macosx/framework/Headers/Public/VLCMedia.h b/projects/macosx/framework/Headers/Public/VLCMedia.h</span><br><span>index 1322332..29e9578 100644</span><br><span>--- a/projects/macosx/framework/Headers/Public/VLCMedia.h</span><br><span>+++ b/projects/macosx/framework/Headers/Public/VLCMedia.h</span><br><span>@@ -332,15 +332,21 @@ extern NSString *VLCMediaTracksInformationTypeUnknown;</span><br><span> */</span><br><span> - (void)parse;</span><br><span></span><br><span>-/**************************************************************************</span><br><span>+/**</span><br><span> * Add options to the media, that will be used to determine how</span><br><span> * VLCMediaPlayer will read the media. This allow to use VLC advanced</span><br><span> * reading/streaming options in a per-media basis</span><br><span> *</span><br><span> * The options are detailed in vlc --long-help, for instance "--sout-all"</span><br><span> * And on the web: <a href="http://wiki.videolan.org/VLC_command-line_help"></a><a href="http://wiki.videolan.org/VLC_command-line_help">http://wiki.videolan.org/VLC_command-line_help</a></span><br><span>-</span><br><span>-**************************************************************************/</span><br><span>+*/</span><br><span> - (void) addOptions:(NSDictionary*) options;</span><br><span></span><br><span>+/**</span><br><span>+ * Getter for statistics information</span><br><span>+ * Returns a NSDictionary with NSNumbers for values.</span><br><span>+ *</span><br><span>+ */</span><br><span>+- (NSDictionary*) getStats;</span><font class="Apple-style-span"><font class="Apple-style-span" color="#0023A3"><br></font></font></div></blockquote><div><br></div><div>The "get" prefix is superfluous, and doesn't match our coding style.</div><div><br></div><blockquote type="cite"><div><span> @end</span><br><span>diff --git a/projects/macosx/framework/Sources/VLCMedia.m b/projects/macosx/framework/Sources/VLCMedia.m</span><br><span>index 958591e..eaf0dd3 100644</span><br><span>--- a/projects/macosx/framework/Sources/VLCMedia.m</span><br><span>+++ b/projects/macosx/framework/Sources/VLCMedia.m</span><br><span>@@ -240,7 +240,7 @@ static void HandleMediaParsedChanged(const libvlc_event_t * event, void * self)</span><br><span> libvlc_event_detach(p_em, libvlc_MediaDurationChanged, HandleMediaDurationChanged, self);</span><br><span> libvlc_event_detach(p_em, libvlc_MediaStateChanged, HandleMediaStateChanged, self);</span><br><span> libvlc_event_detach(p_em, libvlc_MediaSubItemAdded, HandleMediaSubItemAdded, self);</span><br><span>- libvlc_event_detach(p_em, libvlc_MediaParsedChanged, HandleMediaParsedChanged, self);</span><br><span>+ libvlc_event_detach(p_em, libvlc_MediaParsedChanged, HandleMediaParsedChanged, self);</span><br><span> [[VLCEventManager sharedManager] cancelCallToObject:self];</span><br><span></span><br><span> // Testing to see if the pointer exists is not required, if the pointer is null</span><br><span>@@ -338,6 +338,34 @@ static void HandleMediaParsedChanged(const libvlc_event_t * event, void * self)</span><br><span> }</span><br><span> }</span><br><span></span><br><span>+- (NSDictionary*) getStats</span><br><span>+{</span><br><span>+ if(!p_md)</span><br><span>+ return NULL;</span><br><span>+</span><br><span>+ NSMutableDictionary *d = [NSMutableDictionary dictionary];</span><br><span>+ libvlc_media_stats_t p_stats;</span><br><span>+ libvlc_media_get_stats(p_md, &p_stats);</span><br><span>+</span><br><span>+ [d setObject:[NSNumber numberWithFloat: p_stats.f_demux_bitrate] forKey:@"demux_bitrate"];</span><br></div></blockquote><div><br></div><div>While we are at it, could we use upper case for key name (demuxBitrate)?</div><div><br></div><div>Thanks for the patches!</div><div><br></div><div>Pierre.</div></div><span><ATT00002..txt></span></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><p class="MsoNormal" style="margin-top: 0cm; margin-right: 0cm; margin-bottom: 12pt; margin-left: 0cm; font-size: 11pt; font-family: Calibri, sans-serif; "><span lang="EN-US" style="font-size: 10pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222">Regards,<br><br></font><b><font class="Apple-style-span" color="#222222">Rune R. Botten<br></font></b></span><span lang="EN-US" style="font-size: 8pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222">Developer<br>+47 98 88 69 68 / </font><font class="Apple-style-span" color="#222222"><a href="mailto:rune.botten@sdg.no"><font class="Apple-style-span" color="#222222">ru</font><font class="Apple-style-span" color="#222222">ne.botten@sdg.no</font></a><br></font></span><span lang="EN-US" style="font-size: 7.5pt; font-family: Verdana, sans-serif; "><font class="Apple-style-span" color="#222222"></font></span><span lang="EN-US" style="font-size: 9pt; font-family: Georgia, serif; color: rgb(123, 123, 123); "><font class="Apple-style-span" color="#222222"> </font><span class="Apple-style-span" style="color: rgb(0, 0, 0); font-family: Calibri, sans-serif; font-size: 15px; "><span lang="EN-US" style="font-size: 7.5pt; font-family: Verdana, sans-serif; "><font class="Apple-style-span" color="#222222"></font></span><span lang="EN-US" style="font-size: 9pt; font-family: Georgia, serif; color: rgb(123, 123, 123); "><font class="Apple-style-span" color="#222222"> </font></span></span><br></span><b><span lang="EN-US" style="font-size: 9pt; font-family: Georgia, serif; color: rgb(31, 73, 125); "> </span></b><b><span lang="EN-US" style="font-size: 7pt; font-family: Georgia, serif; color: rgb(31, 73, 125); "> <br></span></b><span lang="EN-US" style="font-size: 10pt; font-family: Georgia, serif; color: rgb(216, 94, 4); ">Scandinavian Design Group<br></span><b><span lang="EN-US" style="font-size: 7pt; font-family: Georgia, serif; color: rgb(31, 73, 125); "><br></span></b><span lang="EN-US" style="font-size: 8pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222">Visitor address: Sandakerveien 24 c, building c1<br>P.O. Box 4340 Nydalen, NO-0402 Oslo, Norway<br></font><a href="http://www.sdg.no/" style="text-decoration: underline; "><font class="Apple-style-span" color="#222222">www.sdg.no</font></a><font class="Apple-style-span" color="#222222"><o:p></o:p></font></span></p><p class="MsoNormal" style="margin-top: 0cm; margin-right: 0cm; margin-bottom: 12pt; margin-left: 0cm; font-size: 11pt; font-family: Calibri, sans-serif; "><u><span lang="EN-US" style="font-size: 7pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222"><br></font></span></u><span lang="EN-US" style="font-size: 7pt; font-family: Verdana, sans-serif; "><font class="Apple-style-span" color="#222222">TRUTH WELL TOLD.<br></font></span><span lang="EN-US" style="font-size: 7pt; font-family: Verdana, sans-serif; "><font class="Apple-style-span" color="#222222"></font></span><span lang="EN-US" style="font-size: 7pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222"><span class="Apple-style-span" style="font-family: Verdana, sans-serif; "></span><br>Member of McCann Worldgroup, Norway</font></span><span lang="EN-US" style="font-size: 8pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222"> <br></font></span><span lang="EN-US" style="font-size: 7pt; font-family: Georgia, serif; "><font class="Apple-style-span" color="#222222"><br><br></font><i><u><font class="Apple-style-span" color="#222222">Email disclaimer: </font></u></i><font class="Apple-style-span" color="#222222">This message contains information which may be confidential and privileged. Unless you are the intended recipient (or authorized to receive this message for the intended recipient), you may not use, copy, disseminate or disclose to anyone the message or any information contained in the message. If you have received the message in error, please advise the sender by reply e-mail, and delete the message. Thank you very much.</font></span></p></span></div></div></div></span></div></span></div></span></div></span></div></span></div></span></div></span></div></span></span>
</div>
<br></div></body></html>