<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi,</div><div><br></div><div>Intended to post this to the list. Original message below.</div><div><br></div> -J<div><br><div><br><div>Begin forwarded message:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>From: </b></span><span style="font-family:'Helvetica'; font-size:medium;">Juha Jeronen <<a href="mailto:juha.jeronen@jyu.fi">juha.jeronen@jyu.fi</a>><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>Date: </b></span><span style="font-family:'Helvetica'; font-size:medium;">March 8, 2011 0:26:21 GMT+02:00<br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>To: </b></span><span style="font-family:'Helvetica'; font-size:medium;">"Rémi Denis-Courmont" <<a href="mailto:remi@remlab.net">remi@remlab.net</a>><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; font-size:medium; color:rgba(0, 0, 0, 1);"><b>Subject: </b></span><span style="font-family:'Helvetica'; font-size:medium;"><b>Re: [vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 3</b><br></span></div><br><div>Hi,<br><br>On Mar 7, 2011, at 21:21 , Rémi Denis-Courmont wrote:<br><br><blockquote type="cite"><span class="Apple-tab-span" style="white-space:pre"> </span>Hello,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Le dimanche 6 mars 2011 01:26:57 Juha Jeronen, vous avez écrit :<br></blockquote><blockquote type="cite"><blockquote type="cite">Patch split into two as suggested. Aside from that, I updated some of<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">the new comments and removed an unused parameter that was accidentally<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">left in in the previous version.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Please review the attached version. If needed, I can make one more round<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">of changes for this set. After that, I think it's time to declare this<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">set complete :)<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">If I understood the first patch correctly, you're hacking the pitch and <br></blockquote><blockquote type="cite">visible pitch to only copy every second scan line.<br></blockquote><br>Yes, correct. That is the intention of field processing (in the sense the deinterlacer understands it).<br><br>The implementation is based on my interpretation of Laurent's suggestion :)<br><br><br><blockquote type="cite">I'm not sure this belongs <br></blockquote><blockquote type="cite">in the core, if it is only used internally by the deinterlacer. Or if it still <br></blockquote><blockquote type="cite">goes to the core, it may need to be a little bit "cleaner"?<br></blockquote><br>Maybe. I was thinking about this, too. On the other hand, it's a general plane handling operation, but on the other hand, the deinterlacer may be the only part of a video player that cares about old-fashioned concepts such as "fields".<br><br>I can do it either way. It's really up to you and Laurent as to which one you prefer :)<br><br>As for "cleaner", I'll need a bit more specific suggestions :)<br><br><br><blockquote type="cite">In any case, I would recommend wrapping source code to 79 columns or less. I <br></blockquote><blockquote type="cite">know Laurent is sometimes sloppy. But until you get commit rights, you'll have <br></blockquote><blockquote type="cite">to cope with nit-picking people like myself :P<br></blockquote><br>It's ok. Nitpicking is my specialty, too :P<br><br>So, 79 columns it is...<br><br><br> -J<br><br></div></blockquote></div><br></div></body></html>