<br><br><div class="gmail_quote">2011/3/20 Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net">remi@remlab.net</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
There still is a buffer read overflow. And you assume that the format is<br>
stereo without checking.<br>
<font color="#888888"><br></font></blockquote><div>i checked it. See</div><div> <span class="Apple-style-span" style="border-collapse: collapse; color: rgb(80, 0, 80); font-family: arial, sans-serif; font-size: 13px; ">+    if( i_channels < 2 )</span></div>
<span class="Apple-style-span" style="border-collapse: collapse; color: rgb(80, 0, 80); font-family: arial, sans-serif; font-size: 13px; ">+    {<br>+        msg_Warn( p_filter, "Karaoke Filter needs at least two channels." );<br>
+        return VLC_EGENERIC;<br>+    }</span></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><font color="#888888">
--<br>
Rémi Denis-Courmont<br>
<a href="http://www.remlab.info/" target="_blank">http://www.remlab.info/</a><br>
<a href="http://fi.linkedin.com/in/remidenis" target="_blank">http://fi.linkedin.com/in/remidenis</a><br>
</font><div><div></div><div class="h5">_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Pankaj Yadav<br><a href="http://people.videolan.org/~pk" target="_blank">http://people.videolan.org/~pk</a><br>Open Source Enthusiast<br>