<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Tested on KDE4+Konqueror. The suggested patch fixes the issue for
me.<br>
<br>
-J<br>
<br>
<br>
On 05/07/2011 11:12 PM, Jakob Leben wrote:
<blockquote
cite="mid:BANLkTinz9GkHOJRk+fYaQDaibbBi_aid8w@mail.gmail.com"
type="cite">
<div class="gmail_quote">On Sat, May 7, 2011 at 7:45 PM, Ilkka
Ollakka <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:ileoo@videolan.org">ileoo@videolan.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
On Sat, May 07, 2011 at 08:27:45PM +0300, Juha Jeronen wrote:<br>
</blockquote>
<div> </div>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div class="im">
> > On Sat, May 07, 2011 at 01:37:29AM +0200, Jakob
Leben wrote:<br>
> >> For very long time already (couple of months)
opening files by drag&dropping<br>
> >> them onto Qt interface does not work in the
development version on my Linux<br>
> >> (Kubuntu, both 10.10 and 11.04).<br>
<br>
> Doesn't work for me in KDE4+Konqueror. Maybe something
to do with KDE?<br>
<br>
</div>
Yes, seems that konqueror doesn't do Qt::CopyAction on default
dnd, just<br>
Qt::MoveAction. So basicly it could be just to check if action
if either<br>
of those and set it to CopyAction, but not sure if it has some
effects<br>
(and kinda too tired to read documentation about it atm.)</blockquote>
<div><br>
</div>
<div>The change in behavior from 1.1.x to current was introduced
in commi<font class="Apple-style-span" face="arial, helvetica,
sans-serif">t [<span class="Apple-style-span"
style="font-size: 13px;">eeb1cf53993]. Indeed, the
previous behavior must have let through other actions than
Qt::CopyAction, while the current doesn't.</span></font></div>
<div><font class="Apple-style-span" face="arial, helvetica,
sans-serif"><span class="Apple-style-span" style="font-size:
13px;">I don't see any reason for not responding to
MoveAction as well. And I don't see any reason for setting
the action in </span></font><span class="Apple-style-span"
style="font-family: monospace; font-size: 12px; white-space:
pre;">MainInterface::dropEventPlay </span><span
class="Apple-style-span" style="font-size: 12px;
white-space: pre;"><font class="Apple-style-span"
face="arial, helvetica, sans-serif">either, </font></span><span
class="Apple-style-span" style="font-size: 12px;
white-space: pre;"><font class="Apple-style-span"
face="arial, helvetica, sans-serif">as the drop event will
be consumed and not processed any further so after
responding to the event it really doesn't matter what the
action is anymore.</font></span></div>
<div><font class="Apple-style-span" face="arial, helvetica,
sans-serif"><span class="Apple-style-span" style="font-size:
12px; white-space: pre;"><br>
</span></font></div>
<div><font class="Apple-style-span" face="arial, helvetica,
sans-serif"><span class="Apple-style-span" style="font-size:
12px; white-space: pre;">I propose the attached patch.</span></font></div>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="http://mailman.videolan.org/listinfo/vlc-devel">http://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>