Fixed<br><br><div class="gmail_quote">On Sat, Jun 18, 2011 at 12:12 AM, Laurent Aimar <span dir="ltr"><<a href="mailto:fenrir@elivagar.org">fenrir@elivagar.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Sat, Jun 18, 2011 at 12:07:39AM +0530, akash mehrotra wrote:<br>
> Fixes occasional corruption of "equalizer-bands"<br>
<br>
<br>
</div>> diff --git a/modules/gui/qt4/components/extended_panels.cpp b/modules/gui/qt4/components/extended_panels.cpp<br>
> index b3f5501..d58a164 100644<br>
> --- a/modules/gui/qt4/components/extended_panels.cpp<br>
> +++ b/modules/gui/qt4/components/extended_panels.cpp<br>
> @@ -1060,9 +1061,10 @@ char * Equalizer::createValuesFromPreset( int i_preset )<br>
> /* Create the QString in Qt */<br>
> for( int i = 0 ; i< BANDS ;i++ )<br>
> values += QString( " %1" ).arg( eqz_preset_10b[i_preset]->f_amp[i] );<br>
> -<br>
> + std::string s = values.toStdString();<br>
> + const char *psz_values=s.c_str();<br>
> /* Convert it to char * */<br>
> - return strdup( values.toAscii().constData() );<br>
> + return strdup( psz_values );<br>
I don't think this one is needed as the temporary object is only destroy<br>
at the end of the scope (ie when strdup() has returned).<br>
<font color="#888888"><br>
--<br>
fenrir<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
</font></blockquote></div><br>