<br><br><div class="gmail_quote">On Tue, Sep 13, 2011 at 3:43 PM, Juha Jeronen <span dir="ltr"><<a href="mailto:juha.jeronen@jyu.fi">juha.jeronen@jyu.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    I'm not an official developer (and as a user, I don't want the
    feature either), but an idea:<br>
    <br>
    If there is a significant small fraction of users that do want this
    feature, why not make it an advanced option which is off by default?<br>
    <br></div></blockquote><div>Yeah, this is a good idea. Not everybody will want to use this feature. There are disadvantages to using this feature. But for the few who want it, we can make it available as an option, with default=off.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div bgcolor="#FFFFFF" text="#000000">
    (I don't like option proliferation any more than the next guy, but
    customizability sometimes helps in situations like this.)<br><font color="#888888">
    <br>
     -J</font><div><div></div><div class="h5"><br>
    <br>
    <br>
    On 09/13/2011 12:38 PM, sanjeev mk wrote:
    <blockquote type="cite">
      
      <div>Okay, if not many users want it, no problem :).  Many of us
        (me and my colleagues) have found the need for auto-pause,
        especially when we change windows using Alt+Tab, or open a
        browser, or situations like that. When I open my browser to
        quickly check my mail, the video keeps running in the
        background, so I then go back and manually pause it. And we
        already have the pause-when-minimized option, so I decided to
        extend it by adding this feature of pausing when the user not
        actually watching the video playback .  And playback is resumed
        when the user is again watching the video. So, I figured may be
        many others might use it, hence the patch.</div>
      <div><br>
      </div>
      <div>Anyway, for those who want this feature or just want to see
        how it works, use this patch, the one I posted earlier gives
        white space errors. A clean patch:</div>
      <div><br>
      </div>
      <div>Author: Sanjeev M K <<a href="mailto:sanjeevmk4890@gmail.com" target="_blank">sanjeevmk4890@gmail.com</a>>
          IRC Nick : s-mk</div>
      <div><br>
      </div>
      <div>
        <div>diff --git a/modules/gui/qt4/main_interface.cpp
          b/modules/gui/qt4/main_interface.cpp</div>
        <div>index 193bf7f..f3bb2aa 100644</div>
        <div>--- a/modules/gui/qt4/main_interface.cpp</div>
        <div>+++ b/modules/gui/qt4/main_interface.cpp</div>
        <div>@@ -1145,7 +1145,29 @@ void
          MainInterface::changeEvent(QEvent *event)</div>
        <div>         }</div>
        <div>     }</div>
        <div> </div>
        <div>-    QWidget::changeEvent(event);</div>
        <div>+<span style="white-space:pre-wrap"> </span>else
          if( (event->type() == QEvent::ActivationChange) )</div>
        <div>+<span style="white-space:pre-wrap"> </span>{</div>
        <div>+<span style="white-space:pre-wrap"> </span>if(
          THEMIM->getIM()->playingStatus() == PLAYING_S &&</div>
        <div>+<span style="white-space:pre-wrap"> </span>THEMIM->getIM()->hasVideo()
          &&</div>
        <div>+<span style="white-space:pre-wrap"> </span>!THEMIM->getIM()->hasVisualisation()
          &&</div>
        <div>+<span style="white-space:pre-wrap"> </span>var_InheritBool(
          p_intf, "qt-pause-minimized" ) )</div>
        <div>+<span style="white-space:pre-wrap"> </span>{</div>
        <div>+<span style="white-space:pre-wrap"> </span>b_hasPausedWhenInactive=true;</div>
        <div>+<span style="white-space:pre-wrap"> </span>THEMIM->pause();</div>
        <div>+<span style="white-space:pre-wrap"> </span>}</div>
        <div>+<span style="white-space:pre-wrap"> </span>else
          if(THEMIM->getIM()->playingStatus() == PAUSE_S
          &&</div>
        <div>
          +<span style="white-space:pre-wrap"> </span>THEMIM->getIM()->hasVideo()
          &&</div>
        <div>+<span style="white-space:pre-wrap"> </span>!THEMIM->getIM()->hasVisualisation()
          &&</div>
        <div>+<span style="white-space:pre-wrap"> </span>var_InheritBool(
          p_intf, "qt-pause-minimized" ) )</div>
        <div>+<span style="white-space:pre-wrap"> </span>{</div>
        <div>+<span style="white-space:pre-wrap"> </span>if(b_hasPausedWhenInactive)</div>
        <div>+<span style="white-space:pre-wrap"> </span>{</div>
        <div>+<span style="white-space:pre-wrap"> </span>b_hasPausedWhenInactive=false;</div>
        <div>+<span style="white-space:pre-wrap"> </span>THEMIM->play();</div>
        <div>+<span style="white-space:pre-wrap"> </span>}</div>
        <div>+<span style="white-space:pre-wrap"> </span>}</div>
        <div>+</div>
        <div>+<span style="white-space:pre-wrap"> </span>QWidget::changeEvent(event);</div>
        <div> }</div>
        <div> </div>
        <div> /************************************************************************</div>
        <div>diff --git a/modules/gui/qt4/main_interface.hpp
          b/modules/gui/qt4/main_interface.hpp</div>
        <div>index cfac21f..dfd0935 100644</div>
        <div>--- a/modules/gui/qt4/main_interface.hpp</div>
        <div>+++ b/modules/gui/qt4/main_interface.hpp</div>
        <div>@@ -168,6 +168,7 @@ private:</div>
        <div> //    bool                 b_visualSelectorEnabled;</div>
        <div>     bool                 b_plDocked;            ///< Is
          the playlist docked ?</div>
        <div> </div>
        <div>+<span style="white-space:pre-wrap"> </span>bool<span style="white-space:pre-wrap"> </span>
          b_hasPausedWhenInactive;</div>
        <div>     bool                 b_hasPausedWhenMinimized;</div>
        <div>     bool                 b_statusbarVisible;</div>
        <div> </div>
      </div>
      <br>
      <div class="gmail_quote">On Tue, Sep 13, 2011 at 1:12 PM, Kaarlo
        Räihä <span dir="ltr"><<a href="mailto:kaarlo.raiha@gmail.com" target="_blank">kaarlo.raiha@gmail.com</a>></span>
        wrote:<br>
        <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
          <br>
          <div class="gmail_quote">
            <div>2011/9/13 Jean-Paul Saman <span dir="ltr"><<a href="mailto:jpsaman@gmail.com" target="_blank">jpsaman@gmail.com</a>></span><br>
              <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                2011/9/13 Rémi Denis-Courmont <<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>>:<br>
                <div>>   Hello,<br>
                  ><br>
                  > On Monday 12 September 2011, sanjeev mk wrote:<br>
                  >> This patch is a feature addition/request.<br>
                  >> Currently, if the user minimizes VLC , video
                  playback is auto paused and it<br>
                  >> is resumed when the user 'un'minimizes VLC
                  again.<br>
                  >><br>
                  >> The following patch (also attached) adds to
                  the existing feature by<br>
                  >> implementing auto pause of video when VLC
                  Player window is not active or<br>
                  >> does not have keyboard attention. The
                  playback is resumed when VLC Player<br>
                  >> becomes the active window again.<br>
                  ><br>
                  > As a user, I definitely do NOT want this
                  "feature"...<br>
                  <br>
                </div>
                I agree.<br>
              </blockquote>
              <div><br>
              </div>
            </div>
            <div>Some people have requested something like this on
              forums. But maybe the upcoming boss-key feature is more
              what they want.</div>
            <div>
              <div> </div>
            </div>
          </div>
        </blockquote>
        <div><br>
        </div>
        <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
          <div class="gmail_quote">
            <div>
              <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                <br>
                Kind regards,<br>
                <font color="#888888">Jean-Paul Saman<br>
                </font>
                <div>
                  <div>_______________________________________________<br>
                    vlc-devel mailing list<br>
                    To unsubscribe or modify your subscription options:<br>
                    <a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
                  </div>
                </div>
              </blockquote>
            </div>
          </div>
          <br>
          <br>
          _______________________________________________<br>
          vlc-devel mailing list<br>
          To unsubscribe or modify your subscription options:<br>
          <a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
          <br>
        </blockquote>
      </div>
      <br>
      <br clear="all">
      <div><br>
      </div>
      -- <br>
      Regards,
      <div>Sanjeev M K</div>
      <br>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
    </blockquote>
    <br>
  </div></div></div>

<br>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Regards,<div>Sanjeev M K</div><br>