<meta http-equiv="content-type" content="text/html; charset=utf-8"><div>Okay, if not many users want it, no problem :). Many of us (me and my colleagues) have found the need for auto-pause, especially when we change windows using Alt+Tab, or open a browser, or situations like that. When I open my browser to quickly check my mail, the video keeps running in the background, so I then go back and manually pause it. And we already have the pause-when-minimized option, so I decided to extend it by adding this feature of pausing when the user not actually watching the video playback . And playback is resumed when the user is again watching the video. So, I figured may be many others might use it, hence the patch.</div>
<div><br></div><div>Anyway, for those who want this feature or just want to see how it works, use this patch, the one I posted earlier gives white space errors. A clean patch:</div><div><br></div><div>Author: Sanjeev M K <<a href="mailto:sanjeevmk4890@gmail.com">sanjeevmk4890@gmail.com</a>> IRC Nick : s-mk</div>
<div><br></div><div><div>diff --git a/modules/gui/qt4/main_interface.cpp b/modules/gui/qt4/main_interface.cpp</div><div>index 193bf7f..f3bb2aa 100644</div><div>--- a/modules/gui/qt4/main_interface.cpp</div><div>+++ b/modules/gui/qt4/main_interface.cpp</div>
<div>@@ -1145,7 +1145,29 @@ void MainInterface::changeEvent(QEvent *event)</div><div> }</div><div> }</div><div> </div><div>- QWidget::changeEvent(event);</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>else if( (event->type() == QEvent::ActivationChange) )</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>{</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>if( THEMIM->getIM()->playingStatus() == PLAYING_S &&</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>THEMIM->getIM()->hasVideo() &&</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>!THEMIM->getIM()->hasVisualisation() &&</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>var_InheritBool( p_intf, "qt-pause-minimized" ) )</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>{</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>b_hasPausedWhenInactive=true;</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>THEMIM->pause();</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>else if(THEMIM->getIM()->playingStatus() == PAUSE_S &&</div><div>
+<span class="Apple-tab-span" style="white-space:pre"> </span>THEMIM->getIM()->hasVideo() &&</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>!THEMIM->getIM()->hasVisualisation() &&</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>var_InheritBool( p_intf, "qt-pause-minimized" ) )</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>{</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>if(b_hasPausedWhenInactive)</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>{</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>b_hasPausedWhenInactive=false;</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>THEMIM->play();</div>
<div>+<span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div>+</div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>QWidget::changeEvent(event);</div>
<div> }</div><div> </div><div> /************************************************************************</div><div>diff --git a/modules/gui/qt4/main_interface.hpp b/modules/gui/qt4/main_interface.hpp</div><div>index cfac21f..dfd0935 100644</div>
<div>--- a/modules/gui/qt4/main_interface.hpp</div><div>+++ b/modules/gui/qt4/main_interface.hpp</div><div>@@ -168,6 +168,7 @@ private:</div><div> // bool b_visualSelectorEnabled;</div><div> bool b_plDocked; ///< Is the playlist docked ?</div>
<div> </div><div>+<span class="Apple-tab-span" style="white-space:pre"> </span>bool<span class="Apple-tab-span" style="white-space:pre"> </span> b_hasPausedWhenInactive;</div><div> bool b_hasPausedWhenMinimized;</div>
<div> bool b_statusbarVisible;</div><div> </div></div><br><div class="gmail_quote">On Tue, Sep 13, 2011 at 1:12 PM, Kaarlo Räihä <span dir="ltr"><<a href="mailto:kaarlo.raiha@gmail.com">kaarlo.raiha@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br><br><div class="gmail_quote"><div class="im">2011/9/13 Jean-Paul Saman <span dir="ltr"><<a href="mailto:jpsaman@gmail.com" target="_blank">jpsaman@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2011/9/13 Rémi Denis-Courmont <<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>>:<br>
<div>> Hello,<br>
><br>
> On Monday 12 September 2011, sanjeev mk wrote:<br>
>> This patch is a feature addition/request.<br>
>> Currently, if the user minimizes VLC , video playback is auto paused and it<br>
>> is resumed when the user 'un'minimizes VLC again.<br>
>><br>
>> The following patch (also attached) adds to the existing feature by<br>
>> implementing auto pause of video when VLC Player window is not active or<br>
>> does not have keyboard attention. The playback is resumed when VLC Player<br>
>> becomes the active window again.<br>
><br>
> As a user, I definitely do NOT want this "feature"...<br>
<br>
</div>I agree.<br></blockquote><div><br></div></div><div>Some people have requested something like this on forums. But maybe the upcoming boss-key feature is more what they want.</div><div class="im"><div> </div></div></div>
</blockquote><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Kind regards,<br>
<font color="#888888">Jean-Paul Saman<br>
</font><div><div></div><div>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
</div></div></blockquote></div></div><br>
<br>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="http://mailman.videolan.org/listinfo/vlc-devel" target="_blank">http://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Regards,<div>Sanjeev M K</div><br>