<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>Am 30.01.2012 um 21:09 schrieb Jean-Baptiste Kempf:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Mon, Jan 30, 2012 at 09:00:33PM +0100, David Fuhrmann wrote :<br><blockquote type="cite"><br></blockquote><blockquote type="cite">Am 30.01.2012 um 20:42 schrieb Jean-Baptiste Kempf:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">On Mon, Jan 30, 2012 at 08:39:31PM +0100, David Fuhrmann wrote :<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">My intention was to ask if this could possibly ok for you, before I implement something.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">(See your first mail in this thread.)<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I am sorry, I don't know what you mean by 'this'.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">My idea was to intercept the (main menu) key events before they trigger the appropriate menu action (which would call the respective functions in coreinteraction.m). Then we can use "var_SetInteger( VLCIntf->p_libvlc, "key-action", ACTIONID_VOL_* );" only for these key events and not for all other events (especially clicks on the menu or controls).<br></blockquote><br>No, using key-action is wrong.<br></div></blockquote><div><br></div></div>What is right then, in your opinion?<div><br><div>Should I use aout_Volume*** and additionally copy the appropriate osd calls from hotkeys.c into the gui code?</div><div>Another way could be to modify the core functions, as suggested earlier, e.g.:</div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "><span style="color: #9d2699">int</span> aout_VolumeUp (vlc_object_t *obj, <span style="color: #9d2699">int</span> value, audio_volume_t *volp, bool show_osd_stuff)</div></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "><font class="Apple-style-span" face="Helvetica" size="3">or:</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "><span style="color: rgb(157, 38, 153); ">int</span> aout_VolumeUpAndShowOSD (vlc_object_t *obj, <span style="color: rgb(157, 38, 153); ">int</span> value, audio_volume_t *volp)</div></div></body></html>