<br><br><div class="gmail_quote">On Thu, Mar 15, 2012 at 4:08 PM, Jean-Baptiste Kempf <span dir="ltr"><<a href="mailto:jb@videolan.org">jb@videolan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 15/03/2012 08:44, Sukrit Sangwan wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I have splitted the patches and renamed them.<br>
</blockquote>
<br></div>
Please fix this:<br>
<br>
../../../modules/audio_filter/<u></u>chorus_flanger.c: In function 'DoWork':<br>
../../../modules/audio_filter/<u></u>chorus_flanger.c:257:19: warning: cast from function call of type 'double' to non-matching type 'int' [-Wbad-function-cast]<br></blockquote><div>I have now use floorf() and haven't cast to int.<br>
But i don't know why i didnt get this warning.<br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
../../../modules/audio_filter/<u></u>chorus_flanger.c:249:32: warning: variable 'f_frac' set but not used [-Wunused-but-set-variable]<br>
../../../modules/audio_filter/<u></u>chorus_flanger.c:249:20: warning: variable 'f_diff' set but not used [-Wunused-but-set-variable]<br>
<br>
And please avoid pf_ for floats names<br></blockquote><div>I have changed pf_* to p_* for float.<br><br>Also i have attached the patch for stereo_widen again (i had attached it earlier).<br></div></div><br>-- <br><div>Regards<br>
Sukrit Sangwan</div>
<br>