<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
12.08.2012 19:59, Mark Lee пишет:
<blockquote
cite="mid:CADVdi8pSemvbJLHQjshZ_aM01zRvuLdQ6nvxp2HaoAHbyOzp0w@mail.gmail.com"
type="cite">Hello...<br>
<br>
<div class="gmail_quote">On 12 August 2012 13:33, Alexey Sokolov <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:alexey@asokolov.org" target="_blank">alexey@asokolov.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
12.08.2012 19:29, Rémi Denis-Courmont пишет:<br>
<div class="im">> Le dimanche 12 août 2012 13:49:37 Alexey
Sokolov, vous avez écrit :<br>
>> Hello.<br>
>><br>
>> 12.08.2012 15:30, Mark Lee пишет:<br>
>>> +/**<br>
>>> + * Create a new default equalizer, with all
frequency values zeroed.<br>
>>> + *<br>
>>> + * The new equalizer can subsequently be
associated with a media player<br>
>>> by using + *
libvlc_media_player_set_equalizer().<br>
>>> + *<br>
>>> + * When the application is finished with a
particular equalizer instance<br>
>>> it should + * disassociate it from the media
player by invoking<br>
>>> libvlc_media_player_set_equalizer(NULL) + * and
then free it by using<br>
>>> libvlc_audio_equalizer_release().<br>
>>> + *<br>
>> Why not to use reference count, as other libvlc
objects do?<br>
> Why use a reference count? This is just plain (small)
data.<br>
><br>
> Way overkill.<br>
><br>
</div>
To not to need to maintain validness of the pointer ourself.<br>
If it's so small data, why not to store it inside the
media_player<br>
completely instead?<br>
media_player would just memcpy the data to its field.<br>
</blockquote>
<div><br>
I think one idea was that potentially an equalizer instance
could be shared amongst multiple media players, so making a
copy would not work if that were the case. That idea maybe
strengthens the argument for a refcount.<br>
<br>
</div>
</div>
</blockquote>
Well, if to make them shared amongst multiple media players...
Forcing user to count references on his own is bad.<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards,
Alexey "DarthGandalf" Sokolov</pre>
</body>
</html>