<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 7, 2012, at 5:13 AM, Rémi Denis-Courmont wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Neither names of encoding can be NULL. This patch does not make sense to me.<br><br>-- <br>Rémi Denis-Courmont<br><a href="http://www.remlab.net/">http://www.remlab.net/</a><br>_______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br>http://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote></div><br><div>Nice to get such a fast response.</div><div><br></div><div><div>Not sure what you mean.</div><div>p_item->list.psz[i_index] can be an empty string.</div><div>and if it is, NSString stringWithUTF8String: "" will raise an exception. See both:</div><div><br></div><div>Ticket URL: <<a href="https://trac.videolan.org/vlc/ticket/7539">https://trac.videolan.org/vlc/ticket/7539</a>></div><div><br></div><div><a href="https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/clm/NSString/stringWithUTF8String:">https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/clm/NSString/stringWithUTF8String:</a></div><div><span id="" class="tooltip"><code><a href="https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSString_Class/Reference/NSString.html#//apple_ref/occ/clm/NSString/stringWithUTF8String:">+ stringWithUTF8String:</a></code></span></div><div><span id="" class="tooltip"><br></span></div><div>I think the empty string comes from modules/codec/subsdec.c, line 45</div><div><br></div><div> 41<span class="Apple-tab-span" style="white-space:pre"> </span>/*****************************************************************************</div><div> 42<span class="Apple-tab-span" style="white-space:pre"> </span> * Module descriptor.</div><div> 43<span class="Apple-tab-span" style="white-space:pre"> </span> *****************************************************************************/</div><div> 44<span class="Apple-tab-span" style="white-space:pre"> </span>static const char *const ppsz_encodings[] = {</div><div> 45<span class="Apple-tab-span" style="white-space:pre"> </span> "",</div><div> 46<span class="Apple-tab-span" style="white-space:pre"> </span> "system",</div><div><br></div></div></body></html>