<div dir="ltr">If two different packages provide the same library but with a different versioning, you're screwed with pkg-config. I wasn't part of any debate, but checking against a version number is downright stupid. <div>
If you want to stay with version checking, you need to at least communicate to the user which version of ffmpeg you need or which version of libav.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/4/2 <span dir="ltr"><<a href="mailto:mvergouwe@telenet.be" target="_blank">mvergouwe@telenet.be</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> struct and function when enabling vdpau<br>
X-PHP-Originating-Script: 0:func.inc<br>
MIME-Version: 1.0<br>
Content-Type: text/plain; charset=UTF-8<br>
Content-Transfer-Encoding: 8bit<br>
Date: Tue, 02 Apr 2013 11:38:01 +0200<br>
From: =?UTF-8?Q?R=C3=A9mi_Denis-Courmont?= <<a href="mailto:remi@remlab.net">remi@remlab.net</a>><br>
Cc: Maarten Vergouwe <<a href="mailto:mvergouwe@telenet.be">mvergouwe@telenet.be</a>><br>
In-Reply-To: <<a href="mailto:1364894766-31238-1-git-send-email-mvergouwe@telenet.be">1364894766-31238-1-git-send-email-mvergouwe@telenet.be</a>><br>
References: <<a href="mailto:1364894766-31238-1-git-send-email-mvergouwe@telenet.be">1364894766-31238-1-git-send-email-mvergouwe@telenet.be</a>><br>
Message-ID: <<a href="mailto:db0c673bcae63859543145b7a00f1b65@chewa.net">db0c673bcae63859543145b7a00f1b65@chewa.net</a>><br>
X-Sender: <a href="mailto:remi@remlab.net">remi@remlab.net</a><br>
User-Agent: RoundCube Webmail/0.3.1<br>
<br>
On Tue, 2 Apr 2013 11:26:06 +0200, Maarten Vergouwe <<a href="mailto:mvergouwe@telenet.be">mvergouwe@telenet.be</a>><br>
<br>
wrote:<br>
<br>
> ---<br>
<br>
> <a href="http://configure.ac" target="_blank">configure.ac</a> | 17 ++++++++++-------<br>
<br>
> 1 file changed, 10 insertions(+), 7 deletions(-)<br>
<br>
><br>
<br>
> diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
<br>
> index 6b44139..4d0841d 100644<br>
<br>
> --- a/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
<br>
> +++ b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
<br>
> @@ -3037,16 +3037,19 @@ dnl AM_CONDITIONAL([HAVE_VDPAU], [test<br>
<br>
> "${have_vdpau}" = "yes"])<br>
<br>
><br>
<br>
> have_avcodec_vdpau="no"<br>
<br>
> AS_IF([test "${have_vdpau}" = "yes"], [<br>
<br>
> - PKG_CHECK_EXISTS([libavutil >= 0.52.4 libavcodec >= 54.36.0], [<br>
<br>
> - have_avcodec_vdpau="yes"<br>
<br>
<br>
<br>
This is correct and consistent with upstream's doc/APIchanges.<br>
<br>
<br>
<br>
If this check fails, your upstream version is broken. Not a VLC bug.<br>
<br>
<br>
<br>
> + AC_CHECK_DECL(av_freep, [<br>
<br>
> + AC_CHECK_MEMBER( [struct AVVDPAUContext.decoder], [<br>
<br>
> have_avcodec_vdpau="yes" ], [], [[#include <libavcodec/vdpau.h>]])<br>
<br>
> + ], [], [[#include <libavutil/mem.h>]])<br>
<br>
> +])<br>
<br>
<br>
<br>
No thank you. I wrote and effectively maintain the vdpau plumbing and I<br>
<br>
refuse to have such horrible stuff when pkg-config is superior and easier.<br>
<br>
The libav/ffmpeg version bugs discussion has already been had and I am not<br>
<br>
aware of any upstream change that would grant reopening the debate.<br>
<br>
<br>
<br>
> +<br>
<br>
> +AS_IF([test "${have_avcodec_vdpau}" = "no"], [<br>
<br>
> + AS_IF([test -n "${enable_vdpau}"], [<br>
<br>
> + AC_MSG_ERROR([libavutil >= 0.52.4 (with av_freep) and libavcodec >=<br>
<br>
> 54.87.0 (with struct AVVDPAUContext) are required for VDPAU decoding.])<br>
<br>
<br>
<br>
This is worse than the previous message and also incorrect/inconsistent.<br>
<br>
<br>
<br>
> ], [<br>
<br>
> - AS_IF([test -n "${enable_vdpau}"], [<br>
<br>
> - AC_MSG_ERROR([libavutil >= 0.52.4 and libavcodec >= 54.36.0 are<br>
<br>
> required for VDPAU decoding.])<br>
<br>
> - ], [<br>
<br>
> - AC_MSG_WARN([libavutil >= 0.52.4 and libavcodec >= 54.36.0 are<br>
<br>
> required for VDPAU decoding.])<br>
<br>
> - ])<br>
<br>
> + AC_MSG_WARN([libavutil >= 0.52.4 (with av_freep) and libavcodec >=<br>
<br>
> 54.87.0 (with struct AVVDPAUContext) are required for VDPAU decoding.])<br>
<br>
<br>
<br>
And this is wrong too.<br>
<br>
<br>
<br>
> ])<br>
<br>
> ])<br>
<br>
> +<br>
<br>
> AM_CONDITIONAL([HAVE_AVCODEC_VDPAU], [test "${have_avcodec_vdpau}" =<br>
<br>
> "yes"])<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
<br>
Rémi Denis-Courmont<br>
<br>
Sent from my collocated server<br>
</font></span></blockquote></div><br></div>