<div dir="ltr">Hello! <div>Thank you for the comments!<div><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
> +<br>
> +using namespace ASDCP;<br>
> +<br>
> +#define FRAME_BUFFER_SIZE 4 * 1024 * 1024<br>
<br>
This could maybe include some small mention where/why it is that amount<br></blockquote><div> </div><div style>This is the amount asdcp utilities uses for frame buffer size. I just took it as it is, even though DCI specifications are for maximum 1,302,083 bytes per frame. Should I changed it exactly to this value or aproximate it at about 2 MB?</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
> +/* Module descriptor */<br>
> +vlc_module_begin()<br>
> + set_shortname( N_( "DCP" ) )<br>
> + add_shortcut( "dcp" )<br>
> + set_description( N_( "DCP access-demux module" ) )<br>
> + set_capability( "access_demux", 100 ) /* score? */<br>
<br>
setting capability to 0 means it is only used when forced (eg using<br>
dcp://my/directory) iirc.<br></blockquote><div> </div><div style>It's 100. Anyway, I've changed to 60 to be just bigger than filesystem module with wich it always competes in opening the directory. Please correct me if it's not ok this way.</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
<br>
> +/**<br>
> + * Function which parses XML files in DCP directory in order to get video and audio files<br>
> + * @param p_demux Demux pointer.<br>
> + * @return Integer according to the success or not of the operation<br>
> + */<br>
> +<br>
> + int parserXML ( demux_t * p_demux )<br>
> +{<br>
<br>
> + return 1; /* TODO : perform checking on XML parsing */<br>
<br>
VLC_SUCCESS ?<br></blockquote><div style>Not yet VLC_SUCCESS. It will return VLC_SUCCESS in Open() only after audio and video file were successfully opened with asdcplib. Or did I misunderstood and you were suggesting to use VLC return values in all functions? Is it compulsory, even for intermediary functions? (I mean, other functions than Open(), Control() and Close() ) </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Any particular reason not using vlc xml_reader ability but directly<br>
libxml2?<br></blockquote><div style>No particular reason, I guess. It is not my code there, but I'll ask the students who wrote it, to be sure, and then I'll try using vlc xml_reader. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
> +/**<br>
> + * Function to check if a file name ends with a given suffix<br>
> + * @param str File name<br>
> + * @param suffix Suffix to look for<br>
> + * @return true if the file name ends with the given suffix, fale otherwise<br>
<br>
typo: fail<br></blockquote><div style>This one I didn't understand. </div></div><br></div></div></div></div>