<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> +dnl JPEG decoder module<br>
<br>
Excellent idea! Please do the same for encoder...<br></blockquote><div><br></div><div>Do you mean to write video_output module using libjpeg's encoder?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> +#include <setjmp.h><br>
<br>
brr...<br>
<div class="im"><br>
> +struct decoder_sys_t<br>
> +{<br>
> + struct jpeg_error_mgr err;<br>
> + bool b_error;<br>
> + jmp_buf setjmp_buffer;<br>
> + decoder_t *p_dec;<br>
> +};<br>
<br>
</div>You should clearly repack this structure.<br></blockquote><div><br></div><div>Fixed in upcoming patch.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
No tabs in source code</blockquote><div><br></div><div>Sorry for that, fixed in upcoming patch.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
And you don't eed the {}<br></blockquote><div><br></div><div>Personally I prefer to enclose one-line code blocks with curly braces.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c<br>
> index 8cd821a..04a4c71 100644<br>
> --- a/src/misc/fourcc.c<br>
> +++ b/src/misc/fourcc.c<br>
> @@ -351,8 +351,6 @@ static const staticentry_t p_list_video[] = {<br>
> A("mjpg"),<br>
> A("mJPG"),<br>
> A("mjpa"),<br>
> - A("jpeg"),<br>
> - A("JPEG"),<br>
> A("JFIF"),<br>
> A("JPGL"),<br>
> A("LJPG"),<br>
<br>
</div>Hmm, why?<br></blockquote><div><br></div><div>Image demuxer detects JPEG images incorrectly as Motion JPEG videos.</div><div>This lines dropped from Motion JPEG part only.</div></div><br clear="all"><div><br></div>
-- <br>Maxim Bublis
</div></div>