<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 5, 2014 at 7:29 AM, Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">   Hello,<br>
<br>
On Tue,  4 Mar 2014 23:54:20 -0800, Alex Peak <<a href="mailto:bobcatawareness@gmail.com">bobcatawareness@gmail.com</a>><br>
wrote:<br>
<div class="">> @@ -84,11 +88,12 @@ int playlist_VolumeUp (playlist_t *pl, int value,<br>
> float *volp)<br>
>          float vol = aout_VolumeGet (aout);<br>
>          if (vol >= 0.)<br>
>          {<br>
> -            vol += delta / (float)AOUT_VOLUME_DEFAULT;<br>
> +            vol += delta;<br>
>              if (vol < 0.)<br>
>                  vol = 0.;<br>
>              if (vol > 2.)<br>
>                  vol = 2.;<br>
> +            vol = (round (vol / stepSize)) * stepSize;<br>
<br>
</div>Do you really need double precision round() here?<br></blockquote><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">Nope, roundf should do fine.  That's what I get for thinking in Python... Should I resubmit the patch with the update as v2? </span> </div>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
>              if (volp != NULL)<br>
>                  *volp = vol;<br>
>              ret = aout_VolumeSet (aout, vol);<br>
<br>
--<br>
</div></div><span class=""><font color="#888888">Rémi Denis-Courmont<br>
Sent from my collocated server<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
</font></span></blockquote></div><br></div></div>