<div dir="ltr"><div><div><div>Hello.<br></div>I think it's a bug, but don't sure:<br><a href="http://git.videolan.org/?p=vlc.git;a=blob;f=lib/media_player.c;h=8eee79c7c1406916e81d3e87d48f7b8240a9e9f3;hb=HEAD#l686">http://git.videolan.org/?p=vlc.git;a=blob;f=lib/media_player.c;h=8eee79c7c1406916e81d3e87d48f7b8240a9e9f3;hb=HEAD#l686</a><br>
<br>686 /**************************************************************************<br>687  * Get the Media descriptor associated with the instance.<br>688  **************************************************************************/<br>
689 libvlc_media_t *<br>690 libvlc_media_player_get_media( libvlc_media_player_t *p_mi )<br>691 {<br>692     libvlc_media_t *p_m;<br>693<br>694     lock(p_mi);<br>695     p_m = p_mi->p_md;<br>696     if( p_m )<br>697         libvlc_media_retain( p_mi->p_md );<br>
698     unlock(p_mi);<br>699     return p_mi->p_md;<br>700 }<br><br></div>Should p_m be returned instead of p_mi->p_md?<br>Since unlock was done already, and p_mi->p_md could be changed between<br>unlock(p_mi);<br>
and<br>return p_mi->p_md;<br><br>Or am I missed something?<br></div></div>