<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html><head></head><body><div style="font-size: 12pt; font-family: Calibri,sans-serif;"><div>ARGB is used by X. This is needed for the work-in-progress X RENDER support. I think the current mapping is correct though I have not checked in a few months.</div><div><br></div><div>-- </div><div>Rémi Denis-Courmont</div><div>Sent from my NVIDIA Tegra-powered device</div><br><div id="htc_header">----- Reply message -----<br>De : "Luca Barbato" <lu_zero@gentoo.org><br>Pour : <vlc-devel@videolan.org><br>Objet : [vlc-devel] [PATCH 10/10] video_filter/swscale.c: The mapping for VLC_CODEC_ARGB into PIX_FMT_BGR32_1 is wrong.<br>Date : lun., mai 12, 2014 18:55</div></div><br><pre style="word-wrap: break-word; white-space: pre-wrap;">On 12/05/14 12:04, jpsaman@videolan.org wrote:
> From: Jean-Paul Saman <jpsaman@videolan.org>
>
> Mapping VLC_CODEC_ARGB to PIX_FMT_BGR32_1 maps plane R -> B and B -> R. This makes the colors totally wrong. I believe the correct PIX_FMT mapping should be PIX_FMT_RGB32. Then R -> R, G -> G and B -> B.
>
> Conflicts:
> modules/video_chroma/swscale.c
> ---
> modules/video_chroma/swscale.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/swscale.c
> index 6559078..ea3318e 100644
> --- a/modules/video_chroma/swscale.c
> +++ b/modules/video_chroma/swscale.c
> @@ -271,7 +271,7 @@ static void FixParameters( int *pi_fmt, bool *pb_has_a, bool *pb_swap_uv, vlc_fo
> *pb_has_a = true;
> break;
> case VLC_CODEC_ARGB:
> - *pi_fmt = PIX_FMT_BGR32_1;
> + *pi_fmt = PIX_FMT_RGB32;
> *pb_has_a = true;
> break;
> case VLC_CODEC_YV12:
Seems ok to me, but who is using ARGB as it is ABGR ?
lu
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
</pre></body></html>