<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html><head></head><body><div style="font-size: 12pt; font-family: Calibri,sans-serif;"><div>No. That value males no sense there, period. The _whole_ point of a symbolic constant is that we can change it. And this one has changed.</div><div><br></div><div>Giving it a second meaning is wrong and not acceptable.</div><div><br></div><div>-- </div><div>Rémi Denis-Courmont</div><div>Sent from my NVIDIA Tegra-powered device</div><br><div id="htc_header">----- Reply message -----<br>De : "Francois Cartegnie" <fcvlcdev@free.fr><br>Pour : "Mailing list for VLC media player developers" <vlc-devel@videolan.org><br>Objet : [vlc-devel] [PATCH] demux: avcodec: audio: reset reference time on backward seek (fix #9176)<br>Date : ven., mai 16, 2014 02:25</div></div><br><pre style="word-wrap: break-word; white-space: pre-wrap;">Le 01/05/2014 12:26, Rémi Denis-Courmont a écrit :
>
>> + date_Get(
>> &p_sys->end_date ) - p_block->i_pts > AOUT_MAX_PREPARE_TIME
>> + ) )
> No please. MAX_PREPARE_TIME is only for use by audio outputs (to size play-out
> buffers) and the core (to detect overflow). This really does not belong in
> decoders.
>
I have no real way to guess if there's a discontinuity, as some blocks
might not have duration.
Matching the AOUT_MAX_PREPARE_TIME limit is better than picking an
arbitrary value.
Francois
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
</pre></body></html>