<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 16 June 2014 16:34, Mark Lee <span dir="ltr"><<a href="mailto:mark.lee@capricasoftware.co.uk" target="_blank">mark.lee@capricasoftware.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi...<br><div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">
<div class="">On 16 June 2014 15:47, Adrien Maglo <span dir="ltr"><<a href="mailto:magsoft@gmail.com" target="_blank">magsoft@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This commit repairs the libvlc equalizer API.<br>
---<br>
lib/media_player.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/lib/media_player.c b/lib/media_player.c<br>
index 4477a6a..5225079 100644<br>
--- a/lib/media_player.c<br>
+++ b/lib/media_player.c<br>
@@ -1497,7 +1497,7 @@ int libvlc_media_player_set_equalizer( libvlc_media_player_t *p_mi, libvlc_equal<br>
{<br>
for( unsigned i = 0, c = 0; i < EQZ_BANDS_MAX; i++ )<br>
{<br>
- c = snprintf( bands + c, sizeof(bands) - c, " %.07f",<br>
+ c += snprintf( bands + c, sizeof(bands) - c, " %.07f",<br>
p_equalizer->f_amp[i] );<br>
if( unlikely(c >= sizeof(bands)) )<br>
return -1;<br>
@@ -1517,7 +1517,7 @@ int libvlc_media_player_set_equalizer( libvlc_media_player_t *p_mi, libvlc_equal<br>
var_SetString( p_aout, "equalizer-bands", bands );<br>
}<br>
<br>
- var_SetString( p_mi, "audio-filter", p_equalizer ? "equalizer" : "" );<br>
+ var_SetString( p_aout, "audio-filter", p_equalizer ? "equalizer" : "" );<br></blockquote><div><br></div></div><div>Are you sure about this?<br><br></div><div>I sent the original patch for the equalizer in LibVLC, but it was a while ago and I'm afraid I don't now remember all the detail of why I did it the way I did it, but I can remember that I tested it a lot.<br>
<br></div><div>I wanted to make it so that:<br><br>1. you could set the equalizer *before* an audio output was created (i.e. before you played anything), and it would be applied automatically when the media started; and<br>
2. those settings would be retained and automatically applied when playing one media after another.<br><br>Does this patch still work in that regard if you set it on the aout rather than the media player instance?<br></div>
<div class="">
<div> </div></div></div></div></div></div></blockquote><div><br>Ah, sorry - I didn't have the full code in front of me, just the patch,
when I originally replied. It does indeed look like a typo.<br><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra">
<div class="gmail_quote"><div class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
vlc_object_release( p_aout );<br>
}<br>
<span><font color="#888888"><br>
--<br>
1.9.1<br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
</font></span></blockquote></div></div><span class=""></span></div></div></div></blockquote></div></div></div>