<div dir="ltr">On Thu, Sep 25, 2014 at 7:22 PM, Francois Cartegnie <span dir="ltr"><<a href="mailto:fcvlcdev@free.fr" target="_blank">fcvlcdev@free.fr</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Le 26/09/2014 01:04, Tristan Matthews a écrit :<br>
<span class=""><br>
> +static const char *const enc_chromafmt_list_text[] = {<br>
> +    N_("4:2:0"), N_("4:2:2"), N_("4:4:4")<br>
> +};<br>
>  #endif<br>
<br>
</span>i18n, Really ?<br></blockquote><div><br></div><div>Yeah it seems like it's not translated for schroedinger either, so it could be dropped.<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class=""><br>
<br>
<br>
> +static void SetEncChromaFormat( encoder_t *p_enc, uint32_t i_codec )<br>
> +{<br>
> +    p_enc->fmt_in.i_codec = i_codec;<br>
> +<br>
> +    switch( i_codec ) {<br>
> +    case VLC_CODEC_I420:<br>
> +        p_enc->fmt_in.video.i_bits_per_pixel = 12;<br>
> +        break;<br>
> +    case VLC_CODEC_I422:<br>
> +        p_enc->fmt_in.video.i_bits_per_pixel = 16;<br>
> +        break;<br>
> +    case VLC_CODEC_I444:<br>
> +        p_enc->fmt_in.video.i_bits_per_pixel = 24;<br>
> +        break;<br>
> +    }<br>
> +}<br>
> +<br>
<br>
</span>I believe there's a function that already returns that kind of info.<br>
video_format_Setup() </blockquote><div><br></div><div>Seems like it might be overkill for this case, as we're only changing one parameter and invocation looks like:<br><br>        video_format_Setup( &p_enc->fmt_in, i_codec,<br>                            p_enc->fmt_in.video.i_width,<br>                            p_enc->fmt_in.video.i_height,<br>                            p_enc->fmt_in.video.i_visible_width,<br>                            p_enc->fmt_in.video.i_visible_height,<br>                            p_enc->fmt_in.video.i_sar_num,<br>                            p_enc->fmt_in.video.i_sar_den );<br><br></div><div>but ok.<br></div></div></div></div>