<div dir="ltr">I also just realised there was a typo in the patch that would explain a build error also<br>it had <br><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">size_t_n;<br>instead of<br></span><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">size_t n;<br><br>Updated<br></span><br><div style><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">From 6986255c94efb86291545e7ac50444</span><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">0c6d2e812c Mon Sep 17 00:00:00 2001</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">From: martell <</span><a href="mailto:martellmalone@gmail.com" target="_blank" style="font-family:arial,sans-serif;font-size:12.8000001907349px">martellmalone@gmail.com</a><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">></span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">Date: Mon, 3 Nov 2014 12:38:27 +0000</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">Subject: [PATCH] lfind: msvcrt always use unsigned int* arg</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">---</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> modules/access/dtv/access.c | 9 +++++++--</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> 1 file changed, 7 insertions(+), 2 deletions(-)</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">diff --git a/modules/access/dtv/access.c b/modules/access/dtv/access.c</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">index 95b1dd7..433e65d 100644</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">--- a/modules/access/dtv/access.c</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+++ b/modules/access/dtv/access.c</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">@@ -727,8 +727,13 @@ static const char *var_InheritModulation (vlc_object_t *obj, const char *var)</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> char *mod = var_InheritString (obj, var);</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> if (mod == NULL)</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> return "";</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">-</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">- size_t n = sizeof (modulation_vlc) / sizeof (modulation_vlc[0]);</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+ </span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+#ifdef __MINGW32__</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+ unsigned int n;</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+#else</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+ size_t n;</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+#endif</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">+ n = sizeof (modulation_vlc) / sizeof (modulation_vlc[0]);</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> const char *const *p = lfind (mod, modulation_vlc, &n, sizeof (mod), modcmp);</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> if (p != NULL)</span><br style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px"> {</span><br></div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 4, 2014 at 12:03 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">My advice is to fix MingW and ignore the warning in the mean time.</span></blockquote></span><div><br>The issue here is there is nothing wrong with mingw-w64 as they link to msvcrt<br>As defined here <a href="http://msdn.microsoft.com/en-us/library/a6xkkxfz.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/a6xkkxfz.aspx</a><br><br>On little endian we can just ignore the warning but depending in the strictness of the build / package system this is not an option.<br>I'll CC this to Kai one of the maintainers of mingw-w64 and see whats possible on their end.<br><br>I'm not fully sure but it may or may not be possible for them to change to size_t pointer.<br>Ultimately this is the fault of some Microsoft architect who didn't care about x64 at the time msvcrt was created.<br><br><br> </div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 3, 2014 at 3:58 PM, Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le lundi 03 novembre 2014, 12:58:05 Martell Malone a écrit :<br>
<span>> Their advice is for vlc to make an exception when using lfind.<br>
<br>
</span>My advice is to fix MingW and ignore the warning in the mean time.<br>
<span><font color="#888888"><br>
--<br>
Rémi Denis-Courmont<br>
<a href="http://www.remlab.net/" target="_blank">http://www.remlab.net/</a><br>
</font></span><div><div><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>