<div dir="ltr">After some digging through the archives<br><br><a href="https://mailman.videolan.org/pipermail/vlc-devel/2009-April/058234.html">https://mailman.videolan.org/pipermail/vlc-devel/2009-April/058234.html</a><br><br>Seems <span style="color:rgb(0,0,0);white-space:pre-wrap">HAVE_TIME_H</span> has been removed ?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 12:05 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Moving on from this I am now working on the modules but I am stuck on demux of mkv<br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">C:/msys64/home/Martell/MINGW-packages/mingw-w64-vlc-git/src/vlc/modules/demux/mkv/matroska_segment_parse.cpp: In member function 'void matroska_segment_c::ParseInfo(libmatroska::KaxInfo*)':<br>C:/msys64/home/Martell/MINGW-packages/mingw-w64-vlc-git/src/vlc/modules/demux/mkv/matroska_segment_parse.cpp:904:43: error: 'gmtime_r' was not declared in this scope<br> if( gmtime_r( &i_date, &tmres ) &&<br> ^<br>C:/msys64/home/Martell/MINGW-packages/mingw-w64-vlc-git/src/vlc/modules/demux/mkv/matroska_segment_parse.cpp:906:34: error: 'strftime' was not declared in this scope<br> &tmres ) )<br> ^</blockquote><div><br>looking at matroska_segment_parse.cpp it includes mkv.hpp which has<br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">#ifdef HAVE_CONFIG_H<br># include "config.h"<br>#endif<br>#include <inttypes.h><br>#include <vlc_common.h><br>#include <vlc_plugin.h><br>#ifdef HAVE_TIME_H<br># include <time.h> /* time() */<br>#endif </blockquote><br>at the start so I don't understand why time.h is being missed here ?<br>could it be because it is a .hpp and not a .h file or something silly like this<br>Anyone got any hints?<br><br>Many thanks<span class="HOEnZb"><font color="#888888"><br>Martell</font></span></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 12:03 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Remi,<br><br>This should fix building libvlc under new mingw-w64 trunk in the way you suggested.<br><br><div><div>From 2ae7aa2bbad3b89f8c02696c3ceacdbe1cc82780 Mon Sep 17 00:00:00 2001</div><div>From: Martell Malone <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></div><div>Date: Tue, 25 Nov 2014 11:33:57 +0000</div><div>Subject: [PATCH] added time include to win32 thread</div><div><br></div><div>---</div><div> src/win32/thread.c | 1 +</div><div> 1 file changed, 1 insertion(+)</div><div><br></div><div>diff --git a/src/win32/thread.c b/src/win32/thread.c</div><div>index 7dcfc4c..9bc787d 100644</div><div>--- a/src/win32/thread.c</div><div>+++ b/src/win32/thread.c</div><div>@@ -37,6 +37,7 @@</div><div> #include <assert.h></div><div> #include <limits.h></div><div> #include <errno.h></div><div>+#include <time.h></div><div> </div><div> /*** Static mutex and condition variable ***/</div><div> static vlc_mutex_t super_mutex;</div><span><font color="#888888"><div>-- </div><div>2.1.3</div></font></span></div><br></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 18, 2014 at 7:06 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I will do them all one by one then.<br>I will include time.h in <span style="font-family:arial,sans-serif;font-size:12.8000001907349px">thread.c and any other file that uses the time function.</span><br><br>This does mean that this bug was present in vlc already.<br>It's just HAVE_GMTIME_R and HAVE_LOCALTIME_R were never true for vlc under mingw-w64 before.<br>So the developers never included time.h where they used it<span><br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:12.8000001907349px">You can do whatever is most convenient for you or your organization within your VLC fork or VLC patch series. But upstream, you get to fix bugs properly, even if it means one by one.</span></blockquote><br></span>This is not for another fork of vlc this is so that you guys can build for WinRT under latest trunk<br><br></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 18, 2014 at 6:41 PM, Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le 2014-11-18 19:17, Martell Malone a écrit :<span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If I include time.h in thread.c the error appears somewhere else then<br>
if I patch that it appears somewhere else again and so on.<br>
This is why I changed vlc_fixups.h to fix them all.<br>
<br>
Im not sure if there is another solution but<br>
I can go through them all 1 by 1 if you want ?<br>
It will be time consuming is all.<br>
<br>
Either way I need to get this fixed. :)<br>
</blockquote>
<br></span>
You can do whatever is most convenient for you or your organization within your VLC fork or VLC patch series. But upstream, you get to fix bugs properly, even if it means one by one.<div><div><br>
<br>
-- <br>
Rémi Denis-Courmont<br>
______________________________<u></u>_________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/<u></u>listinfo/vlc-devel</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>