<div dir="ltr">Could we get this applied to the 2.2 branch.<br>I'm trying to get vlc release 2.2 supported by msys2 before next week</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 4, 2014 at 12:48 PM, Martell Malone <span dir="ltr"><<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Myself and jb had discussed a patch over email last month where to find the qt programs I had to change AC_PATH_PROGS to AC_PATH_PROG to successfully find the qt programs on windows. jb quickly pointed out that this was wrong and after a quick lookup I saw that he was correct it should remain as <br>AC_PATH_PROGS.<br><br>So it took some time to figure out but<br><br>The reason for the issue is that on windows if there is a space in the path or if the program is prepends with .exe and we specify the search PATH in AC_PATH_PROGS we must enclose them in quotes or the program will not be found.<br><br>For future reference.<br>If anyone uses AC_PATH_PROGS please enclose defined search paths (if you have any) in quotes<br><br>Can someone test this on other platforms and report on any breakages.<br>I don't expect any.<br><br><div>From d159aa321cd047e0e6b79e57d7221e253c25f59d Mon Sep 17 00:00:00 2001</div><div>From: martell <<a href="mailto:martellmalone@gmail.com" target="_blank">martellmalone@gmail.com</a>></div><div>Date: Tue, 4 Nov 2014 12:39:16 +0000</div><div>Subject: [PATCH] Fix AC_PATH_PROGS for cygwin and msys2</div><div><br></div><div>---</div><div> <a href="http://configure.ac" target="_blank">configure.ac</a> | 10 +++++-----</div><div> 1 file changed, 5 insertions(+), 5 deletions(-)</div><div><br></div><div>diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a></div><div>index 319df97..620d49a 100644</div><div>--- a/<a href="http://configure.ac" target="_blank">configure.ac</a></div><div>+++ b/<a href="http://configure.ac" target="_blank">configure.ac</a></div><div>@@ -3798,9 +3798,9 @@ AS_IF([test "${enable_qt}" != "no"], [</div><div> ])</div><div> QT_PATH="$(eval $PKG_CONFIG --variable=exec_prefix Qt5Core)"</div><div> QT_HOST_PATH="$(eval $PKG_CONFIG --variable=host_bins Qt5Core)"</div><div>- AC_PATH_PROGS(MOC, [moc-qt5 moc], moc, [${QT_HOST_PATH} ${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>- AC_PATH_PROGS(RCC, [rcc-qt5 rcc], rcc, [${QT_HOST_PATH} ${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>- AC_PATH_PROGS(UIC, [uic-qt5 uic], uic, [${QT_HOST_PATH} ${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>+ AC_PATH_PROGS(MOC, [moc-qt5 moc], moc, ["${QT_HOST_PATH}" "${QT_PATH}/bin" "${CONTRIB_DIR}/bin"])</div><div>+ AC_PATH_PROGS(RCC, [rcc-qt5 rcc], rcc, ["${QT_HOST_PATH}" "${QT_PATH}/bin" "${CONTRIB_DIR}/bin"])</div><div>+ AC_PATH_PROGS(UIC, [uic-qt5 uic], uic, ["${QT_HOST_PATH}" "${QT_PATH}/bin" "${CONTRIB_DIR}/bin"])</div><div> ], [</div><div> PKG_CHECK_MODULES([QT], [QtCore QtGui >= 4.6.0],, [</div><div> AS_IF([test -n "${enable_qt}"],[</div><div>@@ -3811,9 +3811,9 @@ AS_IF([test "${enable_qt}" != "no"], [</div><div> enable_qt="no"</div><div> ])</div><div> QT_PATH="$(eval $PKG_CONFIG --variable=exec_prefix QtCore)"</div><div>- AC_PATH_PROGS(MOC, [moc-qt4 moc], moc, [${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>+ AC_PATH_PROGS(MOC, [moc-qt4 moc], moc, ["${QT_PATH}/bin" "${CONTRIB_DIR}/bin"])</div><div> AC_PATH_PROG(RCC, rcc, rcc, [${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>- AC_PATH_PROGS(UIC, [uic-qt4 uic], uic, [${QT_PATH}/bin ${CONTRIB_DIR}/bin])</div><div>+ AC_PATH_PROGS(UIC, [uic-qt4 uic], uic, ["${QT_PATH}/bin" "${CONTRIB_DIR}/bin"])</div><div> ])</div><div> ])</div><div> AS_IF([test "${enable_qt}" != "no"], [</div><span class="HOEnZb"><font color="#888888"><div>-- </div><div>2.1.3</div><div><br></div><br></font></span></div>
</blockquote></div><br></div>