<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>Hi Tristan,<br></div>
<div> </div>
<div>On Wed, Dec 3, 2014, at 21:03, Tristan Matthews wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>> > +<br></div>
<div><div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>> > + /* Feed mpg123 with raw data */<br></div>
<div>> > + i_err = mpg123_feed( p_sys->p_handle, p_block->p_buffer,<br></div>
<div>> > + p_block->i_buffer );<br></div>
<div>> > +<br></div>
<div>> > + if( i_err != MPG123_OK )<br></div>
<div>> > + {<br></div>
<div>> > + msg_Err( p_dec, "mpg123_feed failed: %s", mpg123_plain_strerror(<br></div>
<div>> > i_err ) );<br></div>
<div>> > + block_Release( p_block );<br></div>
<div>> > + return NULL;<br></div>
<div>> > + }<br></div>
<div>> > +<br></div>
<div>> > + /* Get details about the stream */<br></div>
<div>> > + i_err = mpg123_info( p_sys->p_handle, &p_sys->frame_info );<br></div>
<div>> > +<br></div>
<div>> > + if( i_err == MPG123_NEED_MORE )<br></div>
<div>> > + {<br></div>
<div>> > + /* Need moar data */<br></div>
<div>> > + return NULL;<br></div>
</div>
</blockquote><div> </div>
<div>Should block_Release( p_block ) be called here or am I missing something?<br></div>
</div>
</div>
</div>
</blockquote><div> </div>
<div>That's absolutely right. I wrongly took the mpeg_audio module as an example but it does use some helpers that are releasing blocks behind your back in this case.<br></div>
<div> </div>
<div>Thanks.<br></div>
<div id="sig20732453"><div class="signature">--<br></div>
<div class="signature">Ludovic Fauvet<br></div>
<div class="signature">www.videolan.org<br></div>
<div class="signature"> </div>
</div>
<div> </div>
</body>
</html>